Skip Menu |
 

This queue is for tickets about the Text-MicroMason CPAN distribution.

Report information
The Basics
Id: 21802
Status: resolved
Priority: 0/
Queue: Text-MicroMason

People
Owner: Nobody in particular
Requestors: jw35 [...] cam.ac.uk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Posible bugs in Text::MicroMason::Cache::File
Date: Sun, 1 Oct 2006 14:48:00 +0100 (BST)
To: bug-Text-MicroMason [...] rt.cpan.org
From: Jon Warbrick <jw35 [...] cam.ac.uk>
I believe that I have identified two bugs in Text::MicroMason::Cache::File relating to cache expiry: 1) The 'file change' test ($entry->[1] < $mtime) has the inequality the wrong way round (I think, this sort of thing makes my head hurt!) thanks to -M producing weird values, for example ones that are negative for files modified after the program started. In practice this means that a component, once cached, will never be recompiled. 2) When used in conjunction with Text::MicroMason::TemplateDir, Cache::File sees filenames without template_root added. Attempts to use these with -M fail. This means, even with 1) fixed, that a cached component accessed via template_root will still never be recompiled. Bug 2) is a particular pain when developing a Catalyst site using Text::MicroMason! Attached are a test, based on 34-compile_cache.t, showing both of these problems and a trivial patch to resolve the first of these. I've no idea how to go about fixing the second problem. Jon. -- Jon Warbrick Web/News Development, Computing Service, University of Cambridge
Download (untitled) / with headers
text/plain 125b
The following attachment was sent, but NOT saved in the Fcc copy: A Application/x-troff segment of about 1,804 bytes.
Download (untitled) / with headers
text/plain 114b
The following attachment was sent, but NOT saved in the Fcc copy: A Text/PLAIN segment of about 403 bytes.
Subject: Re: [rt.cpan.org #21802] Missing attachments
Date: Sun, 1 Oct 2006 14:52:17 +0100 (BST)
To: Bugs in Text-MicroMason via RT <bug-Text-MicroMason [...] rt.cpan.org>
From: Jon Warbrick <jw35 [...] cam.ac.uk>
Download (untitled) / with headers
text/plain 119b
Missing attachmants attached. Jon. -- Jon Warbrick Web/News Development, Computing Service, University of Cambridge

Message body is not shown because sender requested not to inline it.

Download File.pm.diff
text/x-diff 414b

Message body is not shown because sender requested not to inline it.

CC: evo [...] cpan.org
Subject: [rt.cpan.org #21802] Improved test
Date: Mon, 2 Oct 2006 07:29:46 +0100 (BST)
To: Bugs in Text-MicroMason via RT <bug-Text-MicroMason [...] rt.cpan.org>
From: Jon Warbrick <jw35 [...] cam.ac.uk>
Download (untitled) / with headers
text/plain 176b
Attached an impoved test that doesn't clobber the DTM of a standard test suite file. Jon. -- Jon Warbrick Web/News Development, Computing Service, University of Cambridge

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 1.1k
Deloper version 1.993_01 includes a modified version of the patch and tests you submitted for the cache expiration bug. You're right: the -M comparison was backwards. I have to admit, I've been using Text::MicroMason for years, and it never occurred to me that the cached templates were supposed to expire :) Some previous bug fixes I applied also fix the problem of the interaction of TemplateDir and CompileCache expiration. There were some other TemplateDir cache bugs which I fixed, and the expiration bug seems to have been fixed as a side effect. I will most likely do a 2.0 release "Real Soon Now." Thanks! If you have any other problems with Text::MicroMason, please let me know. Alan Ferrency


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.