Skip Menu |
 

This queue is for tickets about the POE-Component-Client-HTTP CPAN distribution.

Report information
The Basics
Id: 21793
Status: resolved
Priority: 0/
Queue: POE-Component-Client-HTTP

People
Owner: Nobody in particular
Requestors: samlowry [...] e-baka.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: big bug with incorrect urls in POE::Component::Client::HTTP
Date: Sun, 1 Oct 2006 01:49:13 +0400
To: rcaputo [...] cpan.org
From: samlowry <samlowry [...] e-baka.net>
Download (untitled) / with headers
text/plain 370b
Hello! I have big trouble with POE::Component::Client::HTTP on bad urls. For example: http://www.royal4net.net/ redirect me to http:/// suspended.page/ then I get croak 'Must include a 'host' in Client::DNS request at /usr/lib/perl5/site_perl/5.8.7/POE/Component/ Client/DNS.pm line 112'. Do you can to add to POE::Component::Client::HTTP some verifying of urls?
Download (untitled) / with headers
text/plain 628b
On Sat Sep 30 20:44:22 2006, samlowry@e-baka.net wrote: Show quoted text
> Hello! > I have big trouble with POE::Component::Client::HTTP on bad urls. > For example: http://www.royal4net.net/ redirect me to http:/// > suspended.page/ then I get croak 'Must include a 'host' in > Client::DNS request at /usr/lib/perl5/site_perl/5.8.7/POE/Component/ > Client/DNS.pm line 112'. Do you can to add to > POE::Component::Client::HTTP some verifying of urls?
The croak() is bad. I'll see whether I can do something about that. But verifying hosts is going to be hard--- the best way to do it is to ask DNS for an address... and that croaks! :)
Subject: Re: [rt.cpan.org #21793] big bug with incorrect urls in POE::Component::Client::HTTP
Date: Tue, 17 Oct 2006 21:15:53 +0700
To: bug-POE-Component-Client-HTTP [...] rt.cpan.org
From: samlowry <samlowry [...] e-baka.net>
Download (untitled) / with headers
text/plain 876b
You can pre-verify url for presense of default parts - hostname, scheme... (scheme://host). On 10/17/06, via RT <bug-POE-Component-Client-HTTP@rt.cpan.org> wrote: Show quoted text
> > > <URL: http://rt.cpan.org/Ticket/Display.html?id=21793 > > > On Sat Sep 30 20:44:22 2006, samlowry@e-baka.net wrote:
> > Hello! > > I have big trouble with POE::Component::Client::HTTP on bad urls. > > For example: http://www.royal4net.net/ redirect me to http:/// > > suspended.page/ then I get croak 'Must include a 'host' in > > Client::DNS request at /usr/lib/perl5/site_perl/5.8.7/POE/Component/ > > Client/DNS.pm line 112'. Do you can to add to > > POE::Component::Client::HTTP some verifying of urls?
> > > The croak() is bad. I'll see whether I can do something about that. > But verifying hosts is going to be hard--- the best way to do it is to > ask DNS for an address... and that croaks! :) >
Download (untitled) / with headers
text/plain 637b
On Sat Sep 30 20:44:22 2006, samlowry@e-baka.net wrote: Show quoted text
> Hello! > I have big trouble with POE::Component::Client::HTTP on bad urls. > For example: http://www.royal4net.net/ redirect me to http:/// > suspended.page/ then I get croak 'Must include a 'host' in > Client::DNS request at /usr/lib/perl5/site_perl/5.8.7/POE/Component/ > Client/DNS.pm line 112'. Do you can to add to > POE::Component::Client::HTTP some verifying of urls?
Your error message doesn't make sense. The croak() on line 112 should not be repording line 112. Instead it should be reporting the file and line that called resolve(). Please send a test case.
CC: samlowry [...] e-baka.net
Subject: [rt.cpan.org #21793]
Date: Mon, 30 Oct 2006 19:46:03 +0300 (MSK)
To: bug-POE-Component-Client-HTTP [...] rt.cpan.org
From: "Alexander Alexeychuk" <Kikudjiro [...] yandex.ru>
Download (untitled) / with headers
text/plain 334b
Hello! So, in sub poco_weeble_request { in line: unless ($supported_schemes{$http_request->uri->scheme}) { we added: unless ($supported_schemes{$http_request->uri->scheme} && $http_request->uri->host()) { to avoid requests with null (bad) domain names. uri->host() returns nothing in case of bad domain name. Thanks, Alex
Download (untitled) / with headers
text/plain 110b
Oh, I totally misunderstood the original bug. Fix applied as revision 309, which will appear in version 0.82.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.