Skip Menu |
 

This queue is for tickets about the Nagios-Plugin CPAN distribution.

Report information
The Basics
Id: 21493
Status: resolved
Priority: 0/
Queue: Nagios-Plugin

People
Owner: TONVOON [...] cpan.org
Requestors: chris.grim [...] nyu.edu
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: constructor does not set shortname
Date: Thu, 14 Sep 2006 12:54:01 -0400
To: bugs-Nagios-Plugin [...] rt.cpan.org
From: Chris Grim <chris.grim [...] nyu.edu>
Download (untitled) / with headers
text/plain 507b
The pod for Nagios::Plugin, version 0.12, contains the following example in the synopsis: use Nagios::Plugin qw(%ERRORS); $p = Nagios::Plugin->new( shortname => "PAGESIZE" ); However when this code is run, the constructor doesn't actually set the shortname, so when Nagios::Plugin::die() is called, the output is missing the shortname. The attached patch contains a test for this problem (in t/shortname_big.t) and a fix (moving shortname into the Nagios::__::Plugin structure). Chris
Download shortname.patch
text/x-diff 1.1k

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 218b
Chris, Thanks for the report and the patch. Your test case passes with the current code and there are tests that check for this already, so I haven't included the test. N::P 0.14 has just been released to CPAN. Ton


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.