Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 21079
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: alexchorny [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.18_01
Fixed in: (no value)



Subject: Archive error; grep clears @SITE_POLICIES
Download (untitled) / with headers
text/plain 703b
Windows XP. 1. Archive contains 'RequireUpperCaseHeredocTerminator.pm0000644' instead of 'RequireUpperCaseHeredocTerminator.pm' (shown by FAR). My Windows tar unpacks it as 'RequireUpperCaseHeredocTerminator.p'. 2. Tests fails, because in Perl::Critic::Config, sub import, @SITE_POLICIES is empty after grep. File::Spec->catdir returns string with Windows path slashes, but %INC contains Unix path slashes. After replacing my %files = map { $_ => File::Spec->catdir(split m/::/xms, $_) . '.pm' } @SITE_POLICIES; with my %files = map { $a=File::Spec->catdir(split m/::/xms, $_) . '.pm';$a=~s#\\#/#g;$_ => $a } @SITE_POLICIES; all tests pass. ------- Alexandr Ciornii, http://chorny.net
Download (untitled) / with headers
text/plain 1020b
This is very odd. Did you get the tarball from CPAN or from some other packager (like ActiveState)? Could there be something wrong with your `tar` utility? Which perl are you using (please send me `perl -V`)? -Jeff On Sat Aug 19 08:40:12 2006, alexchorny@gmail.com wrote: Show quoted text
> Windows XP. > > 1. Archive contains 'RequireUpperCaseHeredocTerminator.pm0000644' > instead of 'RequireUpperCaseHeredocTerminator.pm' (shown by FAR). My > Windows tar unpacks it as 'RequireUpperCaseHeredocTerminator.p'. > 2. Tests fails, because in Perl::Critic::Config, sub import, > @SITE_POLICIES is empty after grep. > File::Spec->catdir returns string with Windows path slashes, but %INC > contains Unix path slashes. > After replacing > my %files = map { $_ => File::Spec->catdir(split m/::/xms, $_) . > '.pm' } @SITE_POLICIES; > with > my %files = map { $a=File::Spec->catdir(split m/::/xms, $_) . > '.pm';$a=~s#\\#/#g;$_ => $a } @SITE_POLICIES; > all tests pass. > > ------- > Alexandr Ciornii, http://chorny.net
From: Alexandr Ciornii <alexchorny [...] gmail.com>
Download (untitled) / with headers
text/plain 358b
On Aug 20 21:17:47 2006, THALJEF wrote: Show quoted text
> This is very odd. Did you get the tarball from CPAN or from some other > packager (like ActiveState)?
CPAN main mirror. Tested again - same error. But 0.19 unpacks normally. Show quoted text
> Which perl are you using (please send me `perl -V`)?
Attached. Patch still needed for 0.19. ------- Alexandr Ciornii, http://chorny.net
Download perlV
application/octet-stream 2.6k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #21079] Archive error; grep clears @SITE_POLICIES
Date: Mon, 21 Aug 2006 03:10:42 -0700 (PDT)
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeffrey_thalhammer [...] yahoo.com>
Download (untitled) / with headers
text/plain 798b
I can't imagine why your %INC has Unix-style slashes. I'll download ActivePerl later this week and try it out. -Jeff Show quoted text
----- Original Message ---- From: "alexchorny@gmail.com via RT" <bug-Perl-Critic@rt.cpan.org> To: undisclosed-recipients Sent: Monday, August 21, 2006 1:37:02 AM Subject: [rt.cpan.org #21079] Archive error; grep clears @SITE_POLICIES Queue: Perl-Critic Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=21079 > On Aug 20 21:17:47 2006, THALJEF wrote:
> This is very odd. Did you get the tarball from CPAN or from some other > packager (like ActiveState)?
CPAN main mirror. Tested again - same error. But 0.19 unpacks normally.
> Which perl are you using (please send me `perl -V`)?
Attached. Patch still needed for 0.19. ------- Alexandr Ciornii, http://chorny.net
Subject: Re: [rt.cpan.org #21079] Archive error; grep clears @SITE_POLICIES
Date: Mon, 28 Aug 2006 10:21:04 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Chris Dolan <chris [...] clotho.com>
Download (untitled) / with headers
text/plain 1.6k
On Aug 19, 2006, at 7:40 AM, alexchorny@gmail.com via RT wrote: Show quoted text
> > Sat Aug 19 08:40:12 2006: Request 21079 was acted upon. > Transaction: Ticket created by alexchorny@gmail.com > Queue: Perl-Critic > Subject: Archive error; grep clears @SITE_POLICIES > Broken in: 0.18_01 > Severity: Critical > Owner: Nobody > Requestors: alexchorny@gmail.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=21079 > > > > Windows XP. > > 1. Archive contains 'RequireUpperCaseHeredocTerminator.pm0000644' > instead of 'RequireUpperCaseHeredocTerminator.pm' (shown by FAR). My > Windows tar unpacks it as 'RequireUpperCaseHeredocTerminator.p'. > 2. Tests fails, because in Perl::Critic::Config, sub import, > @SITE_POLICIES is empty after grep. > File::Spec->catdir returns string with Windows path slashes, but %INC > contains Unix path slashes. > After replacing > my %files = map { $_ => File::Spec->catdir(split m/::/xms, > $_) . > '.pm' } @SITE_POLICIES; > with > my %files = map { $a=File::Spec->catdir(split m/::/xms, $_) . > '.pm';$a=~s#\\#/#g;$_ => $a } @SITE_POLICIES; > all tests pass. > > ------- > Alexandr Ciornii, http://chorny.net > >
Good catch. A simpler patch would be: my %files = map { $_ => File::Spec::Unix->catdir(split m/::/xms, $_) '.pm' } @SITE_POLICIES; (note the "::Unix") Chris -- Chris Dolan, Software Developer, Clotho Advanced Media Inc. 608-294-7900, fax 294-7025, 1435 E Main St, Madison WI 53703 vCard: http://www.chrisdolan.net/ChrisDolan.vcf Clotho Advanced Media, Inc. - Creators of MediaLandscape Software (http://www.media-landscape.com/) and partners in the revolutionary Croquet project (http://www.opencroquet.org/)
Subject: Re: [rt.cpan.org #21079] Archive error; grep clears @SITE_POLICIES
Date: Mon, 28 Aug 2006 10:22:47 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Chris Dolan <chris [...] clotho.com>
Download (untitled) / with headers
text/plain 791b
On Aug 21, 2006, at 5:15 AM, Jeffrey Thalhammer via RT wrote: Show quoted text
> > Queue: Perl-Critic > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=21079 > > > I can't imagine why your %INC has Unix-style slashes. I'll > download ActivePerl later this week and try it out. > > -Jeff
It's just an implementation detail in Perl to simplify %INC processing code. IMO, it was a bad decision, but there you have it... Chris -- Chris Dolan, Software Developer, Clotho Advanced Media Inc. 608-294-7900, fax 294-7025, 1435 E Main St, Madison WI 53703 vCard: http://www.chrisdolan.net/ChrisDolan.vcf Clotho Advanced Media, Inc. - Creators of MediaLandscape Software (http://www.media-landscape.com/) and partners in the revolutionary Croquet project (http://www.opencroquet.org/)
Subject: grep clears @SITE_POLICIES
From: Alexandr Ciornii <alexchorny [...] gmail.com>
Tests also fail on Vanilla Perl 5.8.8.
From: CLOTHO [...] cpan.org
Download (untitled) / with headers
text/plain 287b
If it's convenient, could you try the latest SVN version of Perl::Critic in Vanilla? svn checkout http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic Jeff tried to fix this bug speculatively, but there isn't a strong Windows presence among the P::C developers... -- Chris
Subject: svn access denied
From: Alexandr Ciornii <alexchorny [...] gmail.com>
Download (untitled) / with headers
text/plain 236b
On Sep 09 19:19:51 2006, CLOTHO wrote: Show quoted text
> If it's convenient, could you try the latest SVN version of Perl::Critic > in Vanilla? > > svn checkout http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic
It requires authorization.
Subject: Re: [rt.cpan.org #21079] svn access denied
Date: Sun, 10 Sep 2006 23:25:32 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Chris Dolan <chris [...] chrisdolan.net>
Download (untitled) / with headers
text/plain 735b
On Sep 10, 2006, at 1:08 AM, alexchorny@gmail.com via RT wrote: Show quoted text
> > Queue: Perl-Critic > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=21079 > > > On Sep 09 19:19:51 2006, CLOTHO wrote:
>> If it's convenient, could you try the latest SVN version of >> Perl::Critic >> in Vanilla? >> >> svn checkout http://perlcritic.tigris.org/svn/perlcritic/trunk/ >> Perl-Critic
> > It requires authorization.
My bad... username: "guest", password: "". That's the standard tigris.org setup for anonymous SVN, but I forgot to communicate that to you. Chris -- Chris Dolan, Software Developer, http://www.chrisdolan.net/ Public key: http://www.chrisdolan.net/public.key vCard: http://www.chrisdolan.net/ChrisDolan.vcf
Subject: Re: [rt.cpan.org #21079] svn access denied
Date: Sun, 10 Sep 2006 23:53:02 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Chris Dolan <chris [...] clotho.com>
Download (untitled) / with headers
text/plain 454b
... or just try the Perl-Critic-0.20 that Jeff just uploaded to CPAN 2 minutes ago. Chris -- Chris Dolan, Software Developer, Clotho Advanced Media Inc. 608-294-7900, fax 294-7025, 1435 E Main St, Madison WI 53703 vCard: http://www.chrisdolan.net/ChrisDolan.vcf Clotho Advanced Media, Inc. - Creators of MediaLandscape Software (http://www.media-landscape.com/) and partners in the revolutionary Croquet project (http://www.opencroquet.org/)
Subject: test
From: alexchorny [...] gmail.com
Download (untitled) / with headers
text/plain 237b
On Sep 09 19:19:51 2006, CLOTHO wrote: Show quoted text
> If it's convenient, could you try the latest SVN version of Perl::Critic > in Vanilla? > > svn checkout http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic
Tests pass on AS & Vanilla.
This is fixed in 0.20. Thanks for verifying it, Alex.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.