Skip Menu |
 

This queue is for tickets about the IO-Socket-SSL CPAN distribution.

Report information
The Basics
Id: 20936
Status: resolved
Priority: 0/
Queue: IO-Socket-SSL

People
Owner: Nobody in particular
Requestors: vela [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: accept() doesn't pass errors to SSL_error_trap
Date: Thu, 10 Aug 2006 17:02:58 +0200
To: bug-IO-Socket-SSL [...] rt.cpan.org
From: Matej Vela <vela [...] debian.org>
Download (untitled) / with headers
text/plain 590b
Hi, With IO::Socket::SSL 0.99 and later, the SSL_error_trap subroutine will always receive an undefined error if accept() fails. The problem is that accept_SSL() sets the error on the listening socket, but calls fatal_ssl_error() on the accepted one. This causes a test failure for HTTP::Daemon::SSL. The following patch sets the error on the accepted socket, as was the case in 0.96. (Note that HTTP::Daemon::SSL also assumes opened() is true even though accept() failed, so it needs an additional one-line patch in order to work with IO::Socket:SSL 0.991 and later.) Thanks, Matej
Download accept-error.diff
text/x-diff 747b

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 158b
Thanks for the bug report. Your patch fixes part of the problem, but there was more (see Changes). But with 0.998 all tests pass again with HTTP::Daemon::SSL.
Subject: Re: [rt.cpan.org #20936] accept() doesn't pass errors to SSL_error_trap
Date: Fri, 11 Aug 2006 12:56:39 +0200
To: bug-IO-Socket-SSL [...] rt.cpan.org
From: Matej Vela <vela [...] debian.org>
Download (untitled) / with headers
text/plain 395b
"Steffen Ullrich via RT" <bug-IO-Socket-SSL@rt.cpan.org> writes: Show quoted text
> Thanks for the bug report. > Your patch fixes part of the problem, but there was more (see Changes). > But with 0.998 all tests pass again with HTTP::Daemon::SSL.
I was aware of the issue with opened() (see original mail), but considered it a bug in HTTP::Daemon::SSL. Anyway, thanks for the prompt response. Cheers, Matej


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.