Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 20633
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: domm [...] cpan.org
Requestors: mbarbon [...] users.sourceforge.net
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.62
Fixed in: (no value)



Subject: Recognize README.txt as a README
Download (untitled) / with headers
text/plain 212b
Hi, I noticed that M::C::A does not recognize README.txt as a README. Since both PAUSE and search.cpan.org do, I thought it would be a good idea if M::C::A did as well. Patch attached. Best regards, Mattia
Subject: mca_readme.diff
Download mca_readme.diff
text/x-diff 2.9k
diff -r -u Module-CPANTS-Analyse-0.62.orig/blib/lib/Module/CPANTS/Kwalitee/Files.pm Module-CPANTS-Analyse-0.62/blib/lib/Module/CPANTS/Kwalitee/Files.pm --- Module-CPANTS-Analyse-0.62.orig/blib/lib/Module/CPANTS/Kwalitee/Files.pm 2006-07-23 12:11:33.000000000 +0200 +++ Module-CPANTS-Analyse-0.62/blib/lib/Module/CPANTS/Kwalitee/Files.pm 2006-07-23 12:14:08.000000000 +0200 @@ -59,7 +59,7 @@ # find special files my %reqfiles; - my @special_files=(qw(Makefile.PL Build.PL README META.yml SIGNATURE MANIFEST NINJA test.pl)); + my @special_files=(qw(Makefile.PL Build.PL META.yml SIGNATURE MANIFEST NINJA test.pl)); foreach my $file (@special_files){ (my $db_file=$file)=~s/\./_/g; $db_file="file_".lc($db_file); @@ -69,6 +69,7 @@ # find more complex files my %regexs=( file_changelog=>qr{^chang(es?|log)|history}i, + file_readme =>qr{^readme(?:\.txt)?}i, ); while (my ($name,$regex)=each %regexs) { $me->d->{$name}=join(',',grep {$_=~/$regex/} @files); diff -r -u Module-CPANTS-Analyse-0.62.orig/blib/man3/Module::CPANTS::Kwalitee::Files.3pm Module-CPANTS-Analyse-0.62/blib/man3/Module::CPANTS::Kwalitee::Files.3pm --- Module-CPANTS-Analyse-0.62.orig/blib/man3/Module::CPANTS::Kwalitee::Files.3pm 2006-07-23 12:11:33.000000000 +0200 +++ Module-CPANTS-Analyse-0.62/blib/man3/Module::CPANTS::Kwalitee::Files.3pm 2006-07-23 12:14:13.000000000 +0200 @@ -129,7 +129,7 @@ .\" ======================================================================== .\" .IX Title "Module::CPANTS::Kwalitee::Files 3" -.TH Module::CPANTS::Kwalitee::Files 3 "2006-07-20" "perl v5.8.4" "User Contributed Perl Documentation" +.TH Module::CPANTS::Kwalitee::Files 3 "2006-07-23" "perl v5.8.4" "User Contributed Perl Documentation" .SH "NAME" Module::CPANTS::Kwalitee::Files \- Check for various files .SH "SYNOPSIS" diff -r -u Module-CPANTS-Analyse-0.62.orig/lib/Module/CPANTS/Kwalitee/Files.pm Module-CPANTS-Analyse-0.62/lib/Module/CPANTS/Kwalitee/Files.pm --- Module-CPANTS-Analyse-0.62.orig/lib/Module/CPANTS/Kwalitee/Files.pm 2006-07-23 12:11:33.000000000 +0200 +++ Module-CPANTS-Analyse-0.62/lib/Module/CPANTS/Kwalitee/Files.pm 2006-07-23 12:14:08.000000000 +0200 @@ -59,7 +59,7 @@ # find special files my %reqfiles; - my @special_files=(qw(Makefile.PL Build.PL README META.yml SIGNATURE MANIFEST NINJA test.pl)); + my @special_files=(qw(Makefile.PL Build.PL META.yml SIGNATURE MANIFEST NINJA test.pl)); foreach my $file (@special_files){ (my $db_file=$file)=~s/\./_/g; $db_file="file_".lc($db_file); @@ -69,6 +69,7 @@ # find more complex files my %regexs=( file_changelog=>qr{^chang(es?|log)|history}i, + file_readme =>qr{^readme(?:\.txt)?}i, ); while (my ($name,$regex)=each %regexs) { $me->d->{$name}=join(',',grep {$_=~/$regex/} @files); Only in Module-CPANTS-Analyse-0.62/lib/Module/CPANTS/Kwalitee: Files.pm~
resolved in 0.63, on it's way to CPAN. Thanks for the pointer and the patch!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.