Skip Menu |
 

This queue is for tickets about the Template-Toolkit CPAN distribution.

Report information
The Basics
Id: 20488
Status: resolved
Priority: 0/
Queue: Template-Toolkit

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 2.15
  • 2.18
Fixed in: (no value)



Subject: fileline.t fails -- expects wrong slashes on Win32
Download (untitled) / with headers
text/plain 432b
FAILED 7: - template text 2 did not match expected MATCH FAILED input: [[% INCLUDE warning -%]\nfile: [% file.chunk(-16).last %]\nline: [% line %]\nwarn: [% warn %]\n] expect: [Hello\nWorld\nfile: test/lib/warning\nline: 2\nwarn: Argument "" isn't numeric in addition (+)] output: [Hello\nWorld\nfile: test\lib\warning\nline: 2\nwarn: Argument "" isn't numeric in addition (+)] not ok 7 - template text 2 did not match expected
From: SMUELLER [...] cpan.org
Download (untitled) / with headers
text/plain 256b
Hi David, hi Andy, the attached patch fixes things on win32 and still works on linux for me. No idea about Mac OS. Applying from within the unpacked distribution directory using the usual "patch -p0 < diff.txt" should work well. Hope this helps, Steffen
Download diff.txt
text/plain 396b
--- t/fileline.t 2006-01-30 16:28:55.000000000 +0100 +++ t/fileline.t 2006-09-10 16:21:10.000000000 +0200 @@ -37,7 +37,9 @@ warning => sub { return $warning }, file => sub { $warning =~ /at (.*?) line/; - return $1; + my $file = $1; + $file =~ s!\\!/!g if defined $file; + return $file; }, line => sub { $warning =~ /line (\d*)/;
Download (untitled) / with headers
text/plain 182b
2.17 has 'fileline.t' skipped on MSWin32. But 2.18 does not have skipping. I think patch is better. Replace should be done only on MSWin32. -- Alexandr Ciornii, http://chorny.net
This was resolved in 2.19


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.