Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the XML-RSS-LibXML CPAN distribution.

Report information
The Basics
Id: 20285
Status: open
Priority: 0/
Queue: XML-RSS-LibXML

People
Owner: Nobody in particular
Requestors: sergeyche [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: V20 formatter breakes on multiple enclosures (patch attached)
Download (untitled) / with headers
text/plain 126b
V20 formatter breaks on multiple enclosures per item. Please fix it in next release (patch attached) Thank you, Sergey
Subject: patch
Download patch
application/octet-stream 1.4k

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 264b
On 火曜日 7月 04 21:44:42 2006, guest wrote: Show quoted text
> V20 formatter breaks on multiple enclosures per item. > > Please fix it in next release (patch attached) > > Thank you, > > Sergey
Thanks, applied as #31. Do you happen to have a test case that I can use?
Download (untitled) / with headers
text/plain 631b
On Wed Jul 05 04:13:15 2006, DMAKI wrote: Show quoted text
> On 火曜日 7月 04 21:44:42 2006, guest wrote:
> > V20 formatter breaks on multiple enclosures per item. > > > > Please fix it in next release (patch attached) > > > > Thank you, > > > > Sergey
> > Thanks, applied as #31. > Do you happen to have a test case that I can use?
I'm not very good at writing tests but I have a test feed used to test FeedValidator: http://www.cadenhead.org/workbench/gems/multi-enclosure-test.xml Actually, subject of multiple enclosures is unclear - see FeedValidator's explanation: http://feedvalidator.org/docs/warning/DuplicateEnclosure.html
Download (untitled) / with headers
text/plain 202b
Show quoted text
> Thanks, applied as #31. > Do you happen to have a test case that I can use?
I wrote some sort of test for this - not sure if it's very good because it's first test I wrote. Let me know if it's good.
# $Id$ # # Sergey Chernyshev <sergeyche@cpan.org> # All rights reserved. # # This test is supposed to test if multiple enclosures get parsed into array # and get rendered into multiple enclosure tags too # # See bug #20285 # http://rt.cpan.org/Public/Bug/Display.html?id=20285 # use strict; use Test::More (tests => 8); BEGIN { use_ok("XML::RSS::LibXML") } my $version = '2.0'; use constant RSS_FEED => qq(<?xml version="1.0"?> <rss version="2.0" xmlns:dc="http://purl.org/dc/elements/1.1/"> <channel> <title>Example 2.0 Channel</title> <link>http://example.com/</link> <description>To lead by example</description> <category>test1</category> <category>test2</category> <item> <title>News for September the Second</title> <link>http://example.com/2002/09/02</link> <description>other things happened today</description> <enclosure url="http://example.com/1.mp3" type="audio/mpeg" length="4096"/> <enclosure url="http://example.com/2.mp3" type="audio/mpeg" length="4096"/> </item> </channel> </rss> ); my $xml = XML::RSS::LibXML->new(); isa_ok($xml,"XML::RSS::LibXML"); eval { $xml->parse(RSS_FEED) }; ok(!$@, "Expected to parse RSS feed from string: $@"); is(ref ($xml->{items}[0]->{enclosure}), 'ARRAY', "Multiple enclosures need to be parsed into array"); is($xml->{items}[0]->{enclosure}[0]->{url}, 'http://example.com/1.mp3', "First enclosure is parsed correctly"); is($xml->{items}[0]->{enclosure}[1]->{url}, 'http://example.com/2.mp3', "Second enclosure is parsed correctly"); my $formatted = $xml->as_string(); ok($formatted=~/<enclosure[^>]url="http:\/\/example.com\/1.mp3"/s, "When rendered, must contain first enclosure - not ARRAY(...)"); ok($formatted=~/<enclosure[^>]url="http:\/\/example.com\/2.mp3"/s, "When rendered, must contain second enclosure two");


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.