Skip Menu |
 

This queue is for tickets about the Net-IP CPAN distribution.

Report information
The Basics
Id: 19759
Status: resolved
Priority: 0/
Queue: Net-IP

People
Owner: Nobody in particular
Requestors: DougB [...] FreeBSD.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.25
Fixed in: (no value)

Attachments


Subject: ipcount errors in 1.25
Download (untitled) / with headers
text/plain 586b
When trying to use ipcount in 1.25, I get the following errors: ipcount -d25 192.168.0/24 Invalid chars in IP 192.168.0.0+127 at /usr/local/bin/ipcount line 83. ipcount -d8 2000::/7 Invalid IP address 2000:0000:0000:0000:0000:0000:0000:0000+1329227995784915872903807060280344575 at /usr/local/bin/ipcount line 83. This is with Math-BigInt-1.77 on three systems, FreeBSD 4.11 running the stock Perl 5.005_03, and FreeBSD 6-stable and 7-current running Perl 5.8.8 from ports. Reverting to Net-IP-1.24 solves this issue for me. I'm happy to test any potential solutions. Doug
From: kmaejima [...] hotmail.com
I think a regex used in ip_normalize() needs to be fixed. Please try the attached patch.
--- Net-IP-1.25/IP.pm.orig 2006-05-23 01:46:40.000000000 +0900 +++ Net-IP-1.25/IP.pm 2006-07-04 17:18:24.000000000 +0900 @@ -1850,7 +1850,7 @@ } # IP + Number - elsif ($data =~ /^(.+?)\s+\+\s+(.+)$/) { + elsif ($data =~ /^(.+?)\s*\+\s*(.+)$/) { ($ip, $len) = ($1, $2); return unless ($ipversion = ip_get_version($ip));
Subject: Re: [rt.cpan.org #19759] ipcount errors in 1.25
Date: Wed, 26 Jul 2006 16:08:37 -0700
To: bug-Net-IP [...] rt.cpan.org
From: Doug Barton <dougb [...] FreeBSD.org>
Download (untitled) / with headers
text/plain 518b
Guest via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=19759 > > > I think a regex used in ip_normalize() needs to be fixed. > Please try the attached patch. >
Please forgive my lateness in responding, but other demands took my attention away from this issue. I've confirmed that this patch solves my issue on both FreeBSD 4.11-Stable using Perl 5.005_03, and FreeBSD 6.1-Stable using Perl 5.8.8. Thanks for looking at this! Regards, Doug -- This .signature sanitized for your protection
Download (untitled) / with headers
text/plain 153b
On Tue Jul 04 04:57:49 2006, guest wrote: Show quoted text
> I think a regex used in ip_normalize() needs to be fixed. > Please try the attached patch.
Comitted, thanks!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.