Skip Menu |
 

This queue is for tickets about the HTTP-DAV CPAN distribution.

Report information
The Basics
Id: 19616
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: HTTP-DAV

People
Owner: OPERA [...] cpan.org
Requestors: mike.bristow [...] thus.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.31
Fixed in: (no value)



Subject: [patch] HTTP::DAV::UserAgent breaks LWP::UserAgent
Download (untitled) / with headers
text/plain 359b
redefining LWP::UserAgent::redirect_ok in HTTP::DAV::UserAgent means that software which uses LWP::UserAgent and HTTP::DAV can break in unexpected ways. We had a script which webscraped some data and generated reports. Adding functionality to upload the reports to a web server for publication broke the webscraping. Using inheritence seem more sensible.
Subject: httpdav.patch
Download httpdav.patch
text/x-diff 728b
Index: HTTP-DAV/DAV/Comms.pm =================================================================== RCS file: /cvsroot/upstream/HTTP-DAV/DAV/Comms.pm,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 Comms.pm --- HTTP-DAV/DAV/Comms.pm 6 Apr 2002 17:45:42 -0000 1.1.1.1 +++ HTTP-DAV/DAV/Comms.pm 31 May 2006 12:47:29 -0000 @@ -10,11 +10,6 @@ use strict; use vars qw($VERSION $DEBUG); -{ - no warnings; - BEGIN { *LWP::UserAgent::redirect_ok = sub { 0 } } -} - #### # Construct a new object and initialize it @@ -312,6 +307,10 @@ $self; } + sub redirect_ok { + return 0; + } + sub credentials { my($self, $netloc, $realm,$user,$pass) = @_; $realm = "default" unless $realm;
This bug has been fixed, with testcase added, in v0.36 soon on CPAN.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.