Skip Menu |
 

This queue is for tickets about the Module-Install CPAN distribution.

Report information
The Basics
Id: 19445
Status: resolved
Priority: 0/
Queue: Module-Install

People
Owner: Nobody in particular
Requestors: mark [...] summersault.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.62
Fixed in: (no value)



Subject: unknown functions in Makefile.PL should fail.
Download (untitled) / with headers
text/plain 216b
Attached is a test script which illustrates that inserting "auto_poop();" into Makefile.PL succeeds which it should fail. Oddly, a warning is reported about an uknown license, when the license is declared. Mark
Subject: auto_poop.t
Download auto_poop.t
text/x-perl 1.5k
use Test; use File::Spec; plan(tests => 3); ok(TestHelper->create_dist('Foo')); ok(not TestHelper->build_dist('Foo')); ok(TestHelper->kill_dist('Foo')); package TestHelper; BEGIN {$^W = 1}; use strict; use File::Spec; use File::Path; use Cwd; use Config; sub create_dist { my ($self, $dist) = @_; my $dist_path = File::Spec->catdir('t', $dist); return 0 if -d $dist_path; my $home = cwd; mkdir($dist_path, 0777) or return 0; chdir $dist_path or return 0; open MANIFEST, '> MANIFEST' or return 0; print MANIFEST <<"END_MANIFEST"; MANIFEST Makefile.PL $dist.pm END_MANIFEST close MANIFEST; open MAKEFILE_PL, '> Makefile.PL' or return 0; print MAKEFILE_PL <<"END_MAKEFILE_PL"; use inc::Module::Install; license 'perl'; # Should fail because auto_poop is not found. auto_poop(); WriteMakefile; END_MAKEFILE_PL close MAKEFILE_PL; open MODULE, "> $dist.pm" or return 0; print MODULE <<"END_PERL_MODULE"; package $dist; \$VERSION = '3.21'; use strict; 1; __END__ =head1 NAME $dist - A test module =cut END_PERL_MODULE close MODULE; chdir $home or return 0; return 1; } sub build_dist { my ($self, $dist) = @_; my $dist_path = File::Spec->catdir('t', $dist); return 0 unless -d $dist_path; my $home = cwd; chdir $dist_path or return 0; system($^X, "-Ilib", "-Iblib/lib", "Makefile.PL") == 0 or return 0; chdir $home or return 0; return 1; } sub kill_dist { my ($self, $dist) = @_; my $dist_path = File::Spec->catdir('t', $dist); File::Path::rmtree($dist_path) or return 0; return 1; } 1;
Subject: Re: [rt.cpan.org #19445] unknown functions in Makefile.PL should fail.
Date: Wed, 24 May 2006 03:04:03 +1000
To: bug-Module-Install [...] rt.cpan.org
From: Adam Kennedy <adam [...] phase-n.com>
Thank you for the bug report, you are a veritable font of testing happyness :) (although sadness for you I guess for now). Again, heh, could you please provide your case with the unknown license as a seperate bug report, attaching both the Makefile.PL in question, and the module it is trying to intuit the license from (your all_from file). If it is proprietary, string out the code as much as possible so that the Makefile.PL still works, then submit that. Thanks again Adam K Guest via RT wrote: Show quoted text
> Tue May 23 12:43:48 2006: Request 19445 was acted upon. > Transaction: Ticket created by guest > Queue: Module-Install > Subject: unknown functions in Makefile.PL should fail. > Broken in: 0.62 > Severity: Normal > Owner: Nobody > Requestors: mark@summersault.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=19445 > > > > Attached is a test script which illustrates that inserting > "auto_poop();" into Makefile.PL succeeds which it should fail. > > Oddly, a warning is reported about an uknown license, when the license > is declared. > > Mark
Download (untitled) / with headers
text/plain 353b
Hi. Added a remedy in the trunk and will be fixed in the next release. Thanks. On 2006-5-23 Tue 12:43:48, guest wrote: Show quoted text
> Attached is a test script which illustrates that inserting > "auto_poop();" into Makefile.PL succeeds which it should fail. > > Oddly, a warning is reported about an uknown license, when the license > is declared. > > Mark
Hi. Module::Install 0.96/0.97 with a fix is out. Thanks.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.