Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 19236
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: mschwern [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.28
Fixed in: (no value)



Subject: INC compat prepending a -I
Download (untitled) / with headers
text/plain 244b
Module::Build::Compat's emulation of INC is incorrectly prepending a -I to the value of INC. This is incorrect because there should already be a -I on the value. That is, INC is used like this: perl Makefile.PL INC=-Ifoo Patch attached.
Subject: fix_INC_compat.patch
Sat May 13 02:27:46 PDT 2006 schwern@pobox.com * Emulation of INC duplicating -I Its "perl Makefile.PL INC=-Ifoo" not "perl Makefile.PL INC=foo" so Compat should not prefix a -I. diff -rN -u old-Module-Build-0.28/lib/Module/Build/Compat.pm new-Module-Build-0.28/lib/Module/Build/Compat.pm --- old-Module-Build-0.28/lib/Module/Build/Compat.pm 2006-05-13 02:30:29.000000000 -0700 +++ new-Module-Build-0.28/lib/Module/Build/Compat.pm 2006-05-13 02:30:29.000000000 -0700 @@ -15,7 +15,7 @@ ( TEST_VERBOSE => 'verbose', VERBINST => 'verbose', - INC => sub { map {('--extra_compiler_flags', "-I$_")} Module::Build->split_like_shell(shift) }, + INC => sub { map {('--extra_compiler_flags', $_)} Module::Build->split_like_shell(shift) }, POLLUTE => sub { ('--extra_compiler_flags', '-DPERL_POLLUTE') }, INSTALLDIRS => sub {local $_ = shift; 'installdirs=' . (/^perl$/ ? 'core' : $_) }, LIB => sub { ('--install_path', 'lib='.shift()) },
From: Randy W. Sims <randys [...] thepierianspring.org>
Download (untitled) / with headers
text/plain 346b
On Sat May 13 05:33:35 2006, MSCHWERN wrote: Show quoted text
> Module::Build::Compat's emulation of INC is incorrectly prepending a -I > to the value of INC. This is incorrect because there should already be > a -I on the value. That is, INC is used like this: > > perl Makefile.PL INC=-Ifoo > > Patch attached.
Thanks. I've applied this patch. Randy.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.