Skip Menu |
 

This queue is for tickets about the Spreadsheet-WriteExcel-Simple CPAN distribution.

Report information
The Basics
Id: 19028
Status: open
Priority: 0/
Queue: Spreadsheet-WriteExcel-Simple

People
Owner: Nobody in particular
Requestors: cpkois [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: bug-Spreadsheet-WriteExcel-Simple [...] rt.cpan.org
Subject: Spreadsheet::WriteExcel::FromDB
Date: Tue, 2 May 2006 08:03:31 -0500
To: tony [...] tmtm.com
From: "Christopher Kois" <cpkois [...] gmail.com>
Download (untitled) / with headers
text/plain 981b
Hello, I've used some of your modules on CPAN and they have been very helpful to me. One of your modules "Spreadsheet::WriteExcel::FromDB" has been a very useful module for viewing the contents of a table. I wanted to modify that module to export the results of a query to an Excel spreadsheet. I've made the modification to the module and have been using it to generate simple Excel reports from database queries. Since the new module was derived from your existing module, I wanted to get your feedback on publishing this new module to CPAN. I would call it "Spreadsheet::WriteExcel::FromDBQuery" and in the POD documentation I would clarify that the module I created was derived from your module with links to your "Spreadsheet::WriteExcel::FromDB", and "Spreadsheet::WriteExcel::Simple" modules. Would you have any objection to this or would you recommend using a different name for the module? Your feedback would be very appreciated. Thank you, Christopher Kois
Subject: Re: [rt.cpan.org #19028] Spreadsheet::WriteExcel::FromDB
Date: Tue, 2 May 2006 14:10:49 +0100
To: Christopher Kois via RT <bug-Spreadsheet-WriteExcel-Simple [...] rt.cpan.org>
From: Tony Bowden <tony [...] kasei.com>
Download (untitled) / with headers
text/plain 1.2k
On Tue, May 02, 2006 at 09:04:02AM -0400, Christopher Kois via RT wrote: Show quoted text
> I wanted to modify > that module to export the results of a query to an Excel spreadsheet. I've > made the modification to the module and have been using it to generate > simple Excel reports from database queries. Since the new module was > derived from your existing module, I wanted to get your feedback on > publishing this new module to CPAN.
When you say "derived from", I presume that it's just a simple subclass that provides a different _data_query() sub? If there was anything more difficult to subclass then I'd appreciate it if you could let me know so that I could look at making it simpler. Show quoted text
> "Spreadsheet::WriteExcel::FromDBQuery" and in the POD documentation I would > clarify that the module I created was derived from your module with links to > your "Spreadsheet::WriteExcel::FromDB", and > "Spreadsheet::WriteExcel::Simple" modules. Would you have any objection to > this or would you recommend using a different name for the module?
The name seems mostly fine, although I would have have a very slight preference for ::FromDB::Query, so that it's more clearly 'under' this module, rather than parallel to it. But that's entirely up to you. Tony
Subject: Re: [rt.cpan.org #19028] Spreadsheet::WriteExcel::FromDB
Date: Tue, 2 May 2006 09:36:51 -0500
To: bug-Spreadsheet-WriteExcel-Simple [...] rt.cpan.org
From: "Christopher Kois" <cpkois [...] gmail.com>
Download (untitled) / with headers
text/plain 2.4k
That is correct, it is just a simple subclass that provides a _data_query sub. It also requires the use of another module to parse the sql query. The fields in the query are assumed to be the fields that are used for the report (I figured why would someone put the fields in the query if they don't want them returned in the report). I've modified the module name to be Spreadsheet::WriteExcel::FromDB::Query so that it shows that the module was derived from your code. Would you prefer if I kept the code from Spreadsheet::WriteExcel::FromDB in it's entirety in the Spreadsheet::WriteExcel::FromDB::Query module or can I remove the portions of the code that it won't be using (like the ignore_columns, include_columns functions)? I would just inherit from it, but the module doesn't have a new function, just a read function that blesses the new object, and I can't think of a way to simply add the fields without taking your original code and modifying it. Thank you again for your feedback, Christopher Kois On 5/2/06, Tony Bowden via RT <bug-Spreadsheet-WriteExcel-Simple@rt.cpan.org> wrote: Show quoted text
> > > <URL: http://rt.cpan.org/Ticket/Display.html?id=19028 > > > On Tue, May 02, 2006 at 09:04:02AM -0400, Christopher Kois via RT wrote:
> > I wanted to modify > > that module to export the results of a query to an Excel
> spreadsheet. I've
> > made the modification to the module and have been using it to generate > > simple Excel reports from database queries. Since the new module was > > derived from your existing module, I wanted to get your feedback on > > publishing this new module to CPAN.
> > When you say "derived from", I presume that it's just a simple subclass > that provides a different _data_query() sub? If there was anything more > difficult to subclass then I'd appreciate it if you could let me know so > that I could look at making it simpler. >
> > "Spreadsheet::WriteExcel::FromDBQuery" and in the POD documentation I
> would
> > clarify that the module I created was derived from your module with
> links to
> > your "Spreadsheet::WriteExcel::FromDB", and > > "Spreadsheet::WriteExcel::Simple" modules. Would you have any objection
> to
> > this or would you recommend using a different name for the module?
> > The name seems mostly fine, although I would have have a very slight > preference for ::FromDB::Query, so that it's more clearly 'under' this > module, rather than parallel to it. But that's entirely up to you. > > Tony > >
Subject: Re: [rt.cpan.org #19028] Spreadsheet::WriteExcel::FromDB
Date: Wed, 3 May 2006 07:02:07 +0100
To: Christopher Kois via RT <bug-Spreadsheet-WriteExcel-Simple [...] rt.cpan.org>
From: Tony Bowden <tony [...] kasei.com>
Download (untitled) / with headers
text/plain 705b
On Tue, May 02, 2006 at 10:37:23AM -0400, Christopher Kois via RT wrote: Show quoted text
> Would you > prefer if I kept the code from Spreadsheet::WriteExcel::FromDB in it's > entirety in the Spreadsheet::WriteExcel::FromDB::Query module or can I > remove the portions of the code that it won't be using (like the > ignore_columns, include_columns functions)? I would just inherit from it, > but the module doesn't have a new function, just a read function that > blesses the new object, and I can't think of a way to simply add the fields > without taking your original code and modifying it.
I don't understand this question. If it's just a subclass why does it need to include any of the code from the parent? Tony
Subject: Re: [rt.cpan.org #19028] Spreadsheet::WriteExcel::FromDB
Date: Wed, 3 May 2006 09:36:03 -0500
To: bug-Spreadsheet-WriteExcel-Simple [...] rt.cpan.org
From: "Christopher Kois" <cpkois [...] gmail.com>
Your right. I apologize, I must have been thinking of something else. I looked at it again and it works just fine as a subclass. Thanks again for your feedback! Thanks, Chris On 5/3/06, Tony Bowden via RT <bug-Spreadsheet-WriteExcel-Simple@rt.cpan.org> wrote: Show quoted text
> > > <URL: http://rt.cpan.org/Ticket/Display.html?id=19028 > > > On Tue, May 02, 2006 at 10:37:23AM -0400, Christopher Kois via RT wrote:
> > Would you > > prefer if I kept the code from Spreadsheet::WriteExcel::FromDB in it's > > entirety in the Spreadsheet::WriteExcel::FromDB::Query module or can I > > remove the portions of the code that it won't be using (like the > > ignore_columns, include_columns functions)? I would just inherit from
> it,
> > but the module doesn't have a new function, just a read function that > > blesses the new object, and I can't think of a way to simply add the
> fields
> > without taking your original code and modifying it.
> > I don't understand this question. If it's just a subclass why does it > need to include any of the code from the parent? > > Tony > >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.