Skip Menu |
 

This queue is for tickets about the dmake CPAN distribution.

Report information
The Basics
Id: 18967
Status: resolved
Priority: 0/
Queue: dmake

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 4.4-20060206-SHAY
Fixed in: (no value)



Subject: MAXLINELENGTH too short to build DateTime-Locale
Download (untitled) / with headers
text/plain 227b
DateTime-Locale creates a Makefile that has some extremely long continuation lines. dmake fails with the message: dmake: makefile: line 441: Error: -- Input line too long, increase MAXLINELENGTH Sample Makefile attached.
Subject: Makefile
Download Makefile
application/octet-stream 74.4k

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 1.4k
Hi David, On Fri Apr 28 07:24:49 2006, DAGOLDEN wrote: Show quoted text
> DateTime-Locale creates a Makefile that has some extremely long > continuation lines. dmake fails with the message: > > dmake: makefile: line 441: Error: -- Input line too long, increase > MAXLINELENGTH > > Sample Makefile attached.
Thanks for the bug report. I've already had the default MAXLINELENGTH in dmake increased from 2046 to 8190 in the OpenOffice sources that I built my version from (see http://www.openoffice.org/issues/show_bug.cgi?id=47137), but it looks like DateTime-Locale needs an even larger value: something like 21000 or above does the trick. You can actually specify MAXLINELENGTH in the startup.mk file, and this will override the built-in (C coded) default. I have attached a patch here showing you how to do this. The patch increases the value to 32766. (A buffer 2 bytes larger than this value is allocated by dmake, as described in man/dmake.nc.) If you apply this to your dmake installation then DateTime-Locale should now build OK for you. However, it would be better for my CPAN distribution of dmake to be able to build DateTime-Locale without any changes like this being necessary, so I will release a new version in the next week or two containing a larger default MAXLINELENGTH. I just need to check with the OpenOffice people first to see if they want to make the change to their sources; if not then I'll just do it in mine. Cheers, - Steve
Download patch.txt
text/plain 357b
diff -ruN dmake.orig/startup/startup.mk dmake/startup/startup.mk --- dmake.orig/startup/startup.mk 2006-02-06 08:42:11.521101400 +0000 +++ dmake/startup/startup.mk 2006-04-28 13:15:22.940632500 +0100 @@ -209,3 +209,5 @@ # Check for a Local project file, gets parsed before user makefile. .INCLUDE .IGNORE .NOINFER: "project.mk" + +MAXLINELENGTH = 32766
Download (untitled) / with headers
text/plain 341b
I've now released a new version of dmake in which, amongst other changes, this bug is fixed by increasing the default MAXLINELENGTH to 32766 as mentioned before. The new version is available from: http://search.cpan.org/~shay/dmake-4.5-20060619-SHAY/ Apologies for this having taken rather longer than I had originally said it would take.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.