Skip Menu |
 

This queue is for tickets about the Kwiki-Archive-Rcs CPAN distribution.

Report information
The Basics
Id: 18947
Status: new
Priority: 0/
Queue: Kwiki-Archive-Rcs

People
Owner: Nobody in particular
Requestors: fmerges [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.15
Fixed in: (no value)

Attachments


Subject: Method fetch_metadata contain errors
Download (untitled) / with headers
text/plain 305b
Calling to 'rlog' syntax in the fetch_metadata method is wrong, this mean that always the last revision is shown instead of the wanted revision... Also the revision value for the variable is wrong, because it's not sanitized as in the fetch method. Attached patch solve this issues... Regards, Florian
Subject: patch-kwiki-archive-rcs.patch
--- Desktop/Rcs.pm 2006-04-27 02:47:18.933762240 +0100 +++ Rcs.pm 2006-04-27 02:52:37.518330024 +0100 @@ -50,8 +50,9 @@ sub fetch_metadata { my $page = shift; my $rev = shift; + $rev = "1.$rev"; my $rcs_file_path = $self->assert_file_path($page); - my $rlog = io("rlog -zLT -r $rev $rcs_file_path |") or die $!; + my $rlog = io("rlog -zLT -r$rev $rcs_file_path |") or die $!; $rlog->utf8 if $self->has_utf8; $self->parse_metadata($rlog->all); }


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.