Skip Menu |
 

This queue is for tickets about the Kwiki-Revisions CPAN distribution.

Report information
The Basics
Id: 18946
Status: new
Priority: 0/
Queue: Kwiki-Revisions

People
Owner: Nobody in particular
Requestors: fmerges [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.15
Fixed in: (no value)

Attachments


Subject: Metadata is not from the given revision
Download (untitled) / with headers
text/plain 417b
When going through the revisions it doesn't use the metadata for the given revision, instead the metadata from the latest revision is used. The attached patch, resolve this issue by calling the archive object to load the metadata for the given revision. The screen_title is also changed to show the person who edited this revision, think this is very interesting when going through the revisions. Regards, Florian
Subject: patch-kwiki-revisions.patch
--- Desktop/Revisions.pm 2006-04-27 02:46:04.744040792 +0100 +++ Revisions.pm 2006-04-27 02:35:35.316728288 +0100 @@ -39,7 +39,9 @@ my $archive = $self->hub->archive; $page->content($archive->fetch($page, $revision_id)); my $page_title = $page->title; - my $screen_title = "$page_title <span style=\"font-size:smaller;color:red\">(Revision $revision_id)</span>"; + my $meta_from_revision = $archive->fetch_metadata($page, $revision_id); + my $edit_by = $meta_from_revision->{edit_by}; + my $screen_title = "$page_title <span style=\"font-size:smaller;color:red\">(Revision $revision_id, Edited by $edit_by)</span>"; my ($prev, $next); REVISIONS: {


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.