Skip Menu |
 

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 18912
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: MARKSTOS [...] cpan.org
Requestors: makoto [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in:
  • 4.00
  • 4.00_01
  • 4.00_02
  • 4.00_03
  • 4.00_04
  • 4.00_05
  • 4.00_06
  • 4.00_07
  • 4.00_08
  • 4.00_09
  • 4.01
  • 4.02
  • 4.02_01
  • 4.03
  • 4.04
  • 4.05
  • 4.06
  • 4.07
  • 4.08
  • 4.09
  • 4.10
  • 4.11
  • 4.12
  • 4.13
Fixed in: (no value)



Subject: Would you add for compatibility?
Download (untitled) / with headers
text/plain 301b
Session.pm 267a268,277 Show quoted text
> if( @_ == 2){ > my($name,$value) = @_; > if ( $name =~ m/^_SESSION_/ ) { > carp "param(): attempt to write to private parameter"; > return undef; > } > $self->_set_status(STATUS_MODIFIED); > return $self->{_DATA}->{ $name } = $value; > } >
Subject: Re: [rt.cpan.org #18912] Would you add for compatibility?
Date: Tue, 25 Apr 2006 09:50:32 -0400
To: via RT <bug-CGI-Session [...] rt.cpan.org>
From: Mark Stosberg <mark [...] summersault.com>
Download (untitled) / with headers
text/plain 920b
On Tue, Apr 25, 2006 at 07:54:00AM -0400, via RT wrote: Show quoted text
> > Tue Apr 25 07:53:57 2006: Request 18912 was acted upon. > Transaction: Ticket created by MAKOTO > Queue: CGI-Session > Subject: Would you add for compatibility? > Owner: Nobody > Requestors: MAKOTO@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > > > > Session.pm > 267a268,277
> > if( @_ == 2){ > > my($name,$value) = @_; > > if ( $name =~ m/^_SESSION_/ ) { > > carp "param(): attempt to write to private parameter"; > > return undef; > > } > > $self->_set_status(STATUS_MODIFIED); > > return $self->{_DATA}->{ $name } = $value; > > }
Thanks for the contribution MAKOTO. Could you also submit a test a fails with the current version, so I can see what the problem is? Also, you mention "compatibility". Do you know when we broke this compatibility?
CC: MAKOTO [...] cpan.org
Subject: Re: [rt.cpan.org #18912] Would you add for compatibility?
Date: Wed, 26 Apr 2006 13:31:13 +0900
To: bug-CGI-Session [...] rt.cpan.org
From: shin honda <makoto [...] fes-total.com>
Download (untitled) / with headers
text/plain 1.3k
In the former version, the value set when the value was set by the param method was returned. Moreover, the param method of CGI.pm also operates such. However, in 4.xx or later, a set of a value returns 1. I want the param method of CGI::Session to carry out the same operation as the param method of CGI.pm. mark@summersault.com via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > > > On Tue, Apr 25, 2006 at 07:54:00AM -0400, via RT wrote: >
>>Tue Apr 25 07:53:57 2006: Request 18912 was acted upon. >>Transaction: Ticket created by MAKOTO >> Queue: CGI-Session >> Subject: Would you add for compatibility? >> Owner: Nobody >> Requestors: MAKOTO@cpan.org >> Status: new >> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > >> >> >>Session.pm >>267a268,277 >>
>>>if( @_ == 2){ >>> my($name,$value) = @_; >>> if ( $name =~ m/^_SESSION_/ ) { >>> carp "param(): attempt to write to private parameter"; >>> return undef; >>> } >>> $self->_set_status(STATUS_MODIFIED); >>> return $self->{_DATA}->{ $name } = $value; >>>}
> > > Thanks for the contribution MAKOTO. > > Could you also submit a test a fails with the current version, so I can > see what the problem is? > > Also, you mention "compatibility". Do you know when we broke this > compatibility? > > >
From: mleblanc [...] cpan.org
Download (untitled) / with headers
text/plain 1.6k
On Wed Apr 26 00:32:32 2006, makoto@fes-total.com wrote: Show quoted text
> In the former version, the value set when the value was set by the param > method was returned. > Moreover, the param method of CGI.pm also operates such. > However, in 4.xx or later, a set of a value returns 1. > I want the param method of CGI::Session to carry out the same operation > as the param method of CGI.pm. > > mark@summersault.com via RT wrote:
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > > > > > On Tue, Apr 25, 2006 at 07:54:00AM -0400, via RT wrote: > >
> >>Tue Apr 25 07:53:57 2006: Request 18912 was acted upon. > >>Transaction: Ticket created by MAKOTO > >> Queue: CGI-Session > >> Subject: Would you add for compatibility? > >> Owner: Nobody > >> Requestors: MAKOTO@cpan.org > >> Status: new > >> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > > >> > >> > >>Session.pm > >>267a268,277 > >>
> >>>if( @_ == 2){ > >>> my($name,$value) = @_; > >>> if ( $name =~ m/^_SESSION_/ ) { > >>> carp "param(): attempt to write to private parameter"; > >>> return undef; > >>> } > >>> $self->_set_status(STATUS_MODIFIED); > >>> return $self->{_DATA}->{ $name } = $value; > >>>}
> > > > > > Thanks for the contribution MAKOTO. > > > > Could you also submit a test a fails with the current version, so I can > > see what the problem is? > > > > Also, you mention "compatibility". Do you know when we broke this > > compatibility? > > > > > >
>
We've decided to make the case where param has only one key-value pair return the value set. The fix is currently in SVN and should be available for the next release (3.14).
From: mleblanc [...] cpan.org
Download (untitled) / with headers
text/plain 241b
Show quoted text
> We've decided to make the case where param has only one key-value pair > return the value set. The fix is currently in SVN and should be > available for the next release (3.14).
Err, 4.14. Didn't realize what I had typed until I hit send.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.