This queue is for tickets about the XML-Twig CPAN distribution.

Report information
The Basics
Id:
18655
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
cpan [...] pjedwards.co.uk
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
3.23
Fixed in:
3.24

Attachments


Subject: XML-Twig-3.23 PATCH for build,compile,test on VMS
XML-Twig-3.23 Perl 5.87 on VMS Please find attached a diff to get this to build and pass all tests on VMS. Summary of changes: "echo" not a VMS command. Twig.pm.slow not a valid VMS filename (only one period allowed). Used File::Spec->catfile in a few places where / was being used. quote on VMS is " Get perl path from Config. Use vmsish hushed on one-liner system call to supress VMS warnings. Added -Mblib to version check one-liner. No support for "fork" on VMS, one test case edited because of this. If VMS check for symbol "xmlwf" before trying to use it. pushing $Bin onto @INC in a BEGIN block did not work on VMS, so I opted for a "use lib". Thanks, Peter (Stig) Edwards
Subject: XML-Twig-3.23.diff
--- XML-Twig-3.23/Makefile.PL 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/Makefile.PL 2006-04-08 22:50:06.1144536606 -0400 @@ -19,2 +19,2 @@ } } +my $echo = 'echo'; +if ($^O eq 'VMS') { + $echo = 'write sys$output'; +} + WriteMakefile( NAME => 'XML::Twig', ABSTRACT => 'XML, The Perl Way', @@ -29,8 +34,8 @@ dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', }, - 'depend' => { 'Twig.pm' => "FORCE\n\techo \"building Twig.pm\"\n\t\$(PERL) speedup Twig.pm.slow > Twig.pm\n\t\$(PERL) check_optional_modules", + 'depend' => { 'Twig.pm' => "FORCE\n\t$echo \"building Twig.pm\"\n\t\$(PERL) speedup Twig_slow.pm > Twig.pm\n\t\$(PERL) check_optional_modules", 'FORCE' => '', }, ); --- XML-Twig-3.23/MANIFEST 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/MANIFEST 2006-04-08 22:50:06.1144536606 -0400 @@ -2,8 +2,8 @@ Makefile.PL README Changes -Twig.pm.slow +Twig_slow.pm Twig.pm Twig/XPath.pm speedup --- XML-Twig-3.23/t/test1.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test1.t 2006-04-08 22:50:06.1144536606 -0400 @@ -7,0 +7,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; # This just tests a complete twig, no callbacks --- XML-Twig-3.23/t/test2.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test2.t 2006-04-08 22:50:06.1144536606 -0400 @@ -4,0 +4,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; # This tests the doctype and DTD access functions --- XML-Twig-3.23/t/test3.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test3.t 2006-04-08 22:50:06.1144536606 -0400 @@ -5,0 +5,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; # This just tests a complete twig, no callbacks --- XML-Twig-3.23/t/test4.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test4.t 2006-04-08 22:50:06.1144536606 -0400 @@ -4,0 +4,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; $|=1; --- XML-Twig-3.23/t/test_additional.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_additional.t 2006-04-08 22:50:06.1144536606 -0400 @@ -9,0 +9,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; $|=1; @@ -2092,2 +2095,2 @@ is( _hash( normalize_xml( $t->sprint)), _hash( $doc), 'comment before PI (3 PIs)');# test 528 } -# returns a string that has all the chars in the input, ordereÑ, to allow +# returns a string that has all the chars in the input, ordereÃÂ, to allow # comparison of texts without taking the order into consideration sub _hash { return sort split //, $_[0]; } --- XML-Twig-3.23/t/test_class_methods.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_class_methods.t 2006-04-08 22:50:06.1144536606 -0400 @@ -11,0 +11,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; use XML::Twig; --- XML-Twig-3.23/t/test_drop_comments.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_drop_comments.t 2006-04-08 22:50:06.1144536606 -0400 @@ -3,0 +3,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; use XML::Twig; --- XML-Twig-3.23/t/test_errors.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_errors.t 2006-04-08 22:50:06.1144536606 -0400 @@ -7,0 +7,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; #$|=1; @@ -16,2 +19,2 @@ my $TMAX=109; print "1..$TMAX\n"; -my $error_file= "t/test_errors.errors"; +my $error_file= File::Spec->catfile('t','test_errors.errors'); { # test insufficient version of XML::Parser (not that easy, it is already too late here) my $need_version= 2.23; -my $q= $^O eq "MSWin32" ? '"' : "'"; +my $q= ( ($^O eq "MSWin32") || ($^O eq 'VMS') ) ? '"' : "'"; + +# from perlvar +use Config; +my $secure_perl_path = $Config{perlpath}; +if ($^O ne 'VMS') { + $secure_perl_path .= $Config{_exe} unless $secure_perl_path =~ m/$Config{_exe}$/i; +} my $version= $need_version - 0.01; unlink $error_file if -f $error_file; -system( qq{$^X -e$q use XML::Parser; BEGIN { \$XML::Parser::VERSION=$version}; use XML::Twig$q 2> $error_file}); +if ($^O eq 'VMS') { + system( qq{$secure_perl_path $q-Mblib$q -e$q use vmsish qw(hushed);use XML::Parser; BEGIN { \$XML::Parser::VERSION=$version}; use XML::Twig $q 2> $error_file}); +} else { + system( qq{$secure_perl_path $q-Mblib$q -e$q use XML::Parser; BEGIN { \$XML::Parser::VERSION=$version}; use XML::Twig $q 2> $error_file}); +} ok( -f $error_file, "error generated for low version of XML::Parser"); matches( slurp( $error_file), "^need at least XML::Parser version 2\.23", "error message for low version of XML::Parser"); $version= $need_version; unlink $error_file if -f $error_file; -system( qq{$^X -e$q use XML::Parser; BEGIN { \$XML::Parser::VERSION=$version}; use XML::Twig$q 2> $error_file}); +system( qq{$secure_perl_path $q-Mblib$q -e$q use XML::Parser; BEGIN { \$XML::Parser::VERSION=$version}; use XML::Twig $q 2> $error_file}); ok( ! -f $error_file || ! slurp( $error_file), "no error generated for proper version of XML::Parser"); $version= $need_version + 0.01; unlink $error_file if -f $error_file; -system( qq{$^X -e$q use XML::Parser; BEGIN { \$XML::Parser::VERSION=$version}; use XML::Twig$q 2> $error_file}); +system( qq{$secure_perl_path $q-Mblib$q -e$q use XML::Parser; BEGIN { \$XML::Parser::VERSION=$version}; use XML::Twig $q 2> $error_file}); ok( ! -f $error_file || ! slurp( $error_file), "no error generated for high version of XML::Parser"); unlink $error_file if -f $error_file; --- XML-Twig-3.23/t/test_even_more_coverage.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_even_more_coverage.t 2006-04-08 22:50:06.1144536606 -0400 @@ -9,0 +9,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; #$|=1; --- XML-Twig-3.23/t/test_expand_external_entities.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_expand_external_entities.t 2006-04-08 22:50:06.1144536606 -0400 @@ -5,0 +5,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; $|=1; --- XML-Twig-3.23/t/test_keep_atts_order.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_keep_atts_order.t 2006-04-08 22:50:06.1144536606 -0400 @@ -3,0 +3,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; # $Id: test_keep_atts_order.t,v 1.4 2005/08/12 12:21:40 mrodrigu Exp $ --- XML-Twig-3.23/t/test_mark.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_mark.t 2006-04-08 22:50:06.1144536606 -0400 @@ -9,0 +9,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; #$|=1; --- XML-Twig-3.23/t/test_need_io_scalar.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_need_io_scalar.t 2006-04-08 22:50:06.1144536606 -0400 @@ -8,0 +8,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; #$|=1; --- XML-Twig-3.23/t/test_need_use_bytes.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_need_use_bytes.t 2006-04-08 22:50:06.1144536606 -0400 @@ -8,0 +8,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; #$|=1; --- XML-Twig-3.23/t/test_safe_encode.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_safe_encode.t 2006-04-08 22:50:06.1144536606 -0400 @@ -5,0 +5,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; use XML::Twig; --- XML-Twig-3.23/t/test_unique_xpath.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_unique_xpath.t 2006-04-08 22:50:06.1144536606 -0400 @@ -5,0 +5,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; use XML::Twig; --- XML-Twig-3.23/t/test_with_lwp.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_with_lwp.t 2006-04-08 22:50:06.1144536606 -0400 @@ -5,0 +5,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; @@ -41,0 +44,0 @@ { warn "\n\n### warning is normal here ###\n\n"; -my $t= XML::Twig->new->safe_parseurl( 'file:test_with_lwp_no_file.xml'); +my $t=0; +if ($^O ne 'VMS') { + # On VMS we get '%SYSTEM-F-ABORT, abort' and an exit when a file does not exist + # Behaviour is probably different on VMS due to it not having 'fork' to do the + # LWP::UserAgent request and (safe) parse of that request not happening in a child process. + $t = XML::Twig->new->safe_parseurl( 'file:test_with_lwp_no_file.xml'); +} ok( !$t, "no file"); ok( $@=~ m{^no element found}, "no file, error message"); } --- XML-Twig-3.23/t/test_wrapped.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_wrapped.t 2006-04-08 22:50:06.1144536606 -0400 @@ -7,4 +7,7 @@ use Carp; use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; $|=1; --- XML-Twig-3.23/t/test_xml_split.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/test_xml_split.t 2006-04-08 22:50:06.1144536606 -0400 @@ -6,0 +6,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; my $DEBUG=0; --- XML-Twig-3.23/t/xmlxpath_additional.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/xmlxpath_additional.t 2006-04-08 22:50:06.1144536606 -0400 @@ -4,0 +4,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; BEGIN --- XML-Twig-3.23/t/xmlxpath_test1.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/xmlxpath_test1.t 2006-04-08 22:50:06.1144536606 -0400 @@ -7,0 +7,0 @@ use FindBin qw($Bin); BEGIN { unshift @INC, $Bin; } +if ($^O eq 'VMS') { + use lib File::Spec->catdir(File::Spec->curdir,'t'); +} use tools; my $DEBUG=0; --- XML-Twig-3.23/t/zz_dump_config.t 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/t/zz_dump_config.t 2006-04-08 22:50:06.1144536606 -0400 @@ -15,0 +15,0 @@ warn version( XML::Parser, 'required'); +# We obviously have expat on VMS, but a symbol/logical might +# not be set to xmlwf, and when this is the case a +# '%DCL-W-IVVERB, unrecognized command verb - check validity and spelling +# \XMLWF\' +# will be returned. + +my $skip_xmlwf_test = 0; +if ($^O eq 'VMS') { + if(`write sys\$output "''xmlwf'"` !~ m/[a-z]+/i) { + $skip_xmlwf_test = 1; + warn format_warn( 'expat', "Skipping expat (version) test as don't have a symbol for 'xmlwf'."); + } +} + +if (! $skip_xmlwf_test) { # try getting this info my $xmlwf_v= `xmlwf -v`; if( $xmlwf_v=~ m{xmlwf using expat_(.*)$}m) { warn format_warn( 'expat', $1, '(required)'); } else { warn format_warn( 'expat', '<no version information found>'); } +} print "\n"; --- XML-Twig-3.23/Twig.pm 2006-04-08 19:21:43.1144524103 -0400 +++ XML-Twig-3.23/Twig.pm 2006-04-08 22:50:06.1144536606 -0400 @@ -732,0 +732,0 @@ # I should really add extra options to allow better configuration of the # LWP::UserAgent object -# this method forks: +# this method forks (not on VMS it doesn't): # - the child gets the data and copies it to the pipe, # - the parent reads the stream and sends it to XML::Parser # the data is cut it chunks the size of the XML::Parser::Expat buffer @@ -740,6 +740,7 @@ sub _parseurl { my( $t, $safe, $url, $agent)= @_; _use( 'LWP') || croak "LWP not available, needed to use parseurl methods"; + if ($^O ne 'VMS') { pipe( README, WRITEME) or croak "cannot create connected pipes: $!"; if( my $pid= fork) { # parent code: parse the incoming file @@ -762,4 +763,13 @@ close WRITEME; CORE::exit(); # CORE is there for mod_perl (which redefines exit) } + } else { + $|=1; + $agent ||= LWP::UserAgent->new; + my $request = HTTP::Request->new( GET => $url); + my $response = $agent->request( $request); + $response->is_success or croak "$url ", $response->message; + my $result= $safe ? $t->safe_parse($response->content) : $t->parse($response->content); + return $@ ? 0 : $t; + } } # get the (hopefully!) XML data from the URL and
Subject: Re: [rt.cpan.org #18655] XML-Twig-3.23 PATCH for build,compile,test on VMS
Date: Tue, 11 Apr 2006 18:12:56 +0200
To: bug-XML-Twig@rt.cpan.org
From: Michel Rodriguez <mirod@xmltwig.com>
Guest via RT wrote:
Show quoted text
> Please find attached a diff to get this to build and pass all tests on VMS.
Hi, I must be a little thick today, but applying the patch with 'patch -p1 < XML-Twig-3.23.diff' gives me a 'patch: **** malformed patch at line 5' error message. Am I missing something? Great job though, thanks a lot. -- Michel Rodriguez Perl &amp; XML xmltwig.com
From: cpan@pjedwards.co.uk
Show quoted text
> I must be a little thick today, but applying the patch with 'patch -p1
< XML-Twig-3.23.diff' gives me a 'patch: **** malformed patch at line 5'
Show quoted text
> error message. Am I missing something?
Sorry it's a bit tricky creating patches on VMS (filename non case preservation, and limited tools). I just tested the patch on a RH Linux box, using patch version 2.5.4 patch --dry-run --verbose -p0 < XML-Twig-3.23.diff I'm in the directory above the folder XML-Twig-3.23, and I'm using "-p0", not "-p1". I guess this is not how patches are normally created. Anyway it seems to work: Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- XML-Twig-3.23/Makefile.PL 2006-04-08 19:21:43.1144524103 -0400 |+++ XML-Twig-3.23/Makefile.PL 2006-04-08 22:50:06.1144536606 -0400 -------------------------- Patching file XML-Twig-3.23/Makefile.PL using Plan A... Hunk #1 succeeded at 19. Hunk #2 succeeded at 34. ...etc...etc... Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |--- XML-Twig-3.23/Twig.pm 2006-04-08 19:21:43.1144524103 -0400 |+++ XML-Twig-3.23/Twig.pm 2006-04-08 22:50:06.1144536606 -0400 -------------------------- Patching file XML-Twig-3.23/Twig.pm using Plan A... Hunk #1 succeeded at 732. Hunk #2 succeeded at 740. Hunk #3 succeeded at 763. done If it still does not work I can create a new diff. Thanks, Peter (Stig) Edwards
Hi, I went through the patch and integrated the changes to the development version. The one thing I did not do is to rename Twig.pm.slow. Is this really necessary? (the file is not used in installing the module, Twig.pm is generated from it, and it is there for people who want to send patches as they should be done on Twig.pm.slow instead of Twig.pm). What does having this file in the distribution cause on VMS? __ mirod
From: cpan@pjedwards.co.uk
Hello,
Show quoted text
> The one thing I did not do is to rename Twig.pm.slow. Is this really > necessary? (the file is not used in installing the module, Twig.pm is > generated from it, and it is there for people who want to send > patches as they should be done on Twig.pm.slow instead of Twig.pm). > What does having this file in the distribution cause on VMS? > mirod
Valid charcacters for VMS filenames are /[A-Z0-0$_-]/, they are of the format name.extension;version (max length for name and extension are 39 characters). perlport also mentions the 8.3 convention, for maximum portability, onerous a burden though this may appear. I can't actually remember why I changed Twig.pm.slow, it's likely it was just because I wanted to 'fix' the manifest errors. It's also likely that I know if any file in a dist is an invalid filename on VMS, I know that 99% of the time I'm going to need to change the filename to get things to build and test. I just downloaded 3.24, and it's failing a couple of tests, (nothing to do with Twig.pm.slow). t/test_errors....................... %DCL-W-IVVERB, unrecognized command verb - check validity and spelling \}\ -e syntax OK cannot slurp 't/error.log': no such file or directory %RMS-E-FNF, file not found dubious Test returned status 98962 (wstat 512, 0x200) (VMS status is 98962) DIED. FAILED test 110 Failed 1/110 tests, 99.09% okay From line 290 of test_errors.t 290 { my $error="t/error.log"; I edited this to: { my $error=File::Spec->catfile('t','error.log'); use Config; my $secure_perl_path = $Config{perlpath}; if ($^O ne 'VMS') { $secure_perl_path .= $Config{_exe} unless $secure_perl_path =~ m/$Config{_exe}$/i; } my $q= ( ($^O eq "MSWin32") || ($^O eq 'VMS') ) ? '"' : "'"; my $cmd; if ($^O eq 'VMS') { $cmd = "$secure_perl_path ${q}-CSDAL${q} ${q}- MXML::Twig${q} -e $q close STDERR; open( STDERR, qq{>$error}) or die qq {cannot open $error (for STDERR)}; open( FH, qq{$secure_perl_path -p - e 1 t/test_new_features_3.22_xml |}) or die qq($!); XML::Twig->nparse( \\*FH); die qq{OK};$q"; } else { $cmd = "$^X -CSDAL -MXML::Twig -e'close STDERR; open( STDERR, qq{>$error}) or die qq{cannot open $error (for STDERR)}; open( FH, qq{$^X -p -e1 t/test_new_features_3.22.xml |}) or die $!; XML::Twig->nparse( \\*FH); die qq{OK\n};'"; } system $cmd; matches( slurp( $error), "^cannot parse the output of a pipe", 'parse a pipe with perlIO layer set to UTF8 (RT #17500)'); NOTE the filename change: test_new_features_3.22_xml due to only one period being allowed. I've only tested this on VMS. After this change test 110 fails thus: not ok 110 parse a pipe with perlIO layer set to UTF8 (RT #17500): expected to match /^cannot parse the output of a pipe/, got 'OK at -e line 1. ' I've not had a chance to read and fully understand http://rt.cpan.org/Public/Bug/Display.html?id=17500 yet. But thought I'd let you know. Thanks, Peter (Stig) Edwards
From: cpan@pjedwards.co.uk
Show quoted text
> I can't actually remember why I changed Twig.pm.slow
Just remembered. It's because of this line the Makefile.PL 'depend' => { 'Twig.pm' => "FORCE\n\t\$(ECHO) \"building Twig.pm\"\n\t\$(PERL) speedup Twig.pm.slow > Twig.pm\n\t\$(PERL) check_optional_modules", I also dicovered a bug in the previous PATCH I supplied to you. On the line above echo should be: \$(ECHO) and not echo or $echo sorry about that.
Show quoted text
> I just downloaded 3.24, and it's failing a couple of tests, (nothing > to do with Twig.pm.slow).
Show quoted text
> I've not had a chance to read and fully understand > http://rt.cpan.org/Public/Bug/Display.html?id=17500 yet.
So I read the bug above and I think the problem is fixed in 5.87 ??? (Or maybe it is not a problem on VMS) So I edited line 287 of test_errors.t from: { if( $] <= 5.008) to: { if( ( $] <= 5.008) || ($] >= 5.008007) ) this skips the test (for me) and now all test cases pass. Thanks, Peter (Stig) Edwards
Subject: Re: [rt.cpan.org #18655] XML-Twig-3.23 PATCH for build,compile,test on VMS
Date: Fri, 21 Apr 2006 17:42:06 +0200
To: bug-XML-Twig@rt.cpan.org
From: Michel Rodriguez <mirod@xmltwig.com>
Guest via RT wrote:
Show quoted text
> Queue: XML-Twig > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18655 > >
>> I can't actually remember why I changed Twig.pm.slow
> > Just remembered. It's because of this line the Makefile.PL > > 'depend' => { 'Twig.pm' => "FORCE\n\t\$(ECHO) \"building > Twig.pm\"\n\t\$(PERL) speedup Twig.pm.slow > Twig.pm\n\t\$(PERL) > check_optional_modules", > > I also dicovered a bug in the previous PATCH I supplied to you. > On the line above echo should be: > \$(ECHO) > and not > echo > or > $echo > sorry about that.
I removed the echo altogether
Show quoted text
> So I read the bug above and I think the problem is fixed in 5.87 ??? > (Or maybe it is not a problem on VMS) > So I edited line 287 of test_errors.t from: > { if( $] <= 5.008) > to: > { if( ( $] <= 5.008) || ($] >= 5.008007) ) > > this skips the test (for me) and now all test cases pass.
The bug is still there on my machine, so I replaced it with if( ( $] <= 5.008) || ($^O eq 'VMS') ) The new version is at the usual place, let me know if you find anything else, thanks. -- Michel Rodriguez Perl &amp; XML xmltwig.com


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.