Skip Menu |
 

This queue is for tickets about the Date-Tolkien-Shire CPAN distribution.

Report information
The Basics
Id: 18433
Status: resolved
Priority: 0/
Queue: Date-Tolkien-Shire

People
Owner: tbraun [...] pobox.com
Requestors: wyant [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.12
Fixed in: (no value)



Subject: Mis-spelling: "mallorn trea"
Download (untitled) / with headers
text/plain 430b
The on_date() method for March 29 2006 Gregorian = 6 Astron 7470 Shire Reckoning returns the text "The mallorn trea flowers in the party field, 1420." Shouldn't this be "The mallorn tree flowers in the party field, 1420."? The attached file is a universal diff based on Date::Tolkien::Shire version 1.12 that: * Bumps the version to 1.12_001 * Changes "mallorn trea" to "mallorn tree". Picky, picky, picky. Thanks, Tom Wyant
Subject: Shire.diff
Download Shire.diff
text/x-diff 720b
--- Shire.orig Thu Feb 20 21:09:20 2003 +++ Shire.pm Wed Mar 29 11:00:47 2006 @@ -33,7 +33,7 @@ use vars qw($VERSION $ERROR); -$VERSION = 1.12; +$VERSION = 1.12_001; =head1 METHOD REFERENCE @@ -652,7 +652,7 @@ 27 => "Bard II and Thorin III Stonehelm drive the enemy from Dale, 1419.\n", 28 => "Celeborn crosses the Anduin and begins destruction of Dol Guldur, 1419.\n" }; - $events{4} = { 6 => "The mallorn trea flowers in the party field, 1420.\n", + $events{4} = { 6 => "The mallorn tree flowers in the party field, 1420.\n", 8 => "Ring bearers are honored on the fields of Cormallen, 1419.\n", 12 => "Gandalf arrives in Hobbiton, 1418\n" };
Download (untitled) / with headers
text/plain 673b
Fixed. I went ahead and made the version 1.13. It's simple enough anyway that I like to avoid third level version numbers. Thanks for catching this. Tom Braun On Wed Mar 29 12:05:38 2006, WYANT wrote: Show quoted text
> The on_date() method for March 29 2006 Gregorian = 6 Astron 7470 Shire > Reckoning returns the text "The mallorn trea flowers in the party field, > 1420." Shouldn't this be "The mallorn tree flowers in the party field, > 1420."? > > The attached file is a universal diff based on Date::Tolkien::Shire > version 1.12 that: > > * Bumps the version to 1.12_001 > > * Changes "mallorn trea" to "mallorn tree". > > Picky, picky, picky. > > Thanks, > > Tom Wyant
Subject: Re: [rt.cpan.org #18433] Mis-spelling: "mallorn trea"
Date: Thu, 30 Mar 2006 02:42:59 +0000
To: bug-Date-Tolkien-Shire [...] rt.cpan.org
From: harryfmudd [...] comcast.net
Download (untitled) / with headers
text/plain 676b
Show quoted text
-------------- Original message ---------------------- From: " via RT" <bug-Date-Tolkien-Shire@rt.cpan.org>
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=18433 > > > Fixed. I went ahead and made the version 1.13. It's simple enough > anyway that I like to avoid third level version numbers.
Thank you. I had no intent to pre-empt your numbering, which was _why_ I gave it a third-level number. I installed this on my own desktop, and wanted the CPAN update, when it came, to override my version. Anyhow, at least you know you have a user. And I think you'll find another at http://weather.rudis.net/megatrack/ Anyhow, thanks for the prompt response. Tom Wyant
Download (untitled) / with headers
text/plain 133b
No problem on the numbering -- I appreciate the consideration of sending a patch. And it's always good to know I'm not my only user.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.