Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 18106
Status: rejected
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: steve.kirkup [...] dss.virginia.gov
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.2612
Fixed in: (no value)



Subject: sub ACTION_install is not run under fakeinstall
Download (untitled) / with headers
text/plain 395b
I was using subclass to create a new object and then override the ACTION_install code. However, when I ran Build as a fakeinstall it ignores my ACTION_install code. I understand that is probably what you want to happen. Who knows what would get run under ACTION_install when someone does a fakeinstall? I figure that maybe a trap of some sort can be called? At least it should be documented.
Download (untitled) / with headers
text/plain 351b
That's a tricky issue - initially I was about to agree, but I think that some people will be running custom actions in ACTION_install() that really shouldn't be run in a "fake" install. Perhaps the best we can do is note this issue in the docs, and suggest that if people want to be thorough in 'fakeinstall' they override that method too. -Ken
Subject: RE: [rt.cpan.org #18106] sub ACTION_install is not run under fakeinstall
Date: Mon, 13 Mar 2006 08:33:19 -0500
To: <bug-Module-Build [...] rt.cpan.org>
From: "Steve Kirkup" <steve.kirkup [...] dss.virginia.gov>
Ken, Yeah, it is very tricky. If someone is trying to copy files, for example, you would not want someone to copy them in a fake install. I am not sure if you can detect if a method is being overridden so you could issue a warning either. At least if it is documented then it might be able to help someone avoid the problem. Thanks for emailing me, it is nice to know that someone looks at this stuff and cares... :) Steve Kirkup Show quoted text
-----Original Message----- From: Ken_Williams via RT [mailto:bug-Module-Build@rt.cpan.org] Sent: Friday, March 10, 2006 9:42 PM To: steve.kirkup@dss.virginia.gov Subject: [rt.cpan.org #18106] sub ACTION_install is not run under fakeinstall <URL: http://rt.cpan.org/Ticket/Display.html?id=18106 > That's a tricky issue - initially I was about to agree, but I think that some people will be running custom actions in ACTION_install() that really shouldn't be run in a "fake" install. Perhaps the best we can do is note this issue in the docs, and suggest that if people want to be thorough in 'fakeinstall' they override that method too. -Ken
notabug. We'll note in the docs that fakeinstall and install are not connected.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.