Skip Menu |
 

This queue is for tickets about the Net-Domain-TLD CPAN distribution.

Report information
The Basics
Id: 17915
Status: resolved
Priority: 0/
Queue: Net-Domain-TLD

People
Owner: Nobody in particular
Requestors: bricas [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in:
  • 1.63
  • 1.64
  • 1.65
Fixed in: (no value)



Subject: Please resurrect the OO interface and test suite
Download (untitled) / with headers
text/plain 908b
Although it is mentioned in the "Changes" file that, from versions 1.63 onward, the OO interface has been removed and that we can use an old version to get it back -- this seriously breaks new installations of modules that depends on Net::Domain::TLD. Case in point: http://use.perl.org/~LTjake/journal/ To summarize: Email::Store needs Net::Domain::TLD deep down in the chain (via Email::Valid), but the error returned doesn't make much sense (due to the levels of indirection that I have to deal with in the application). Also, Ricardo Signes (RJBS) released version 1.62 which included a great test suite which would ensure that future revisions could be regression tested. Following versions completely removed the test suite in favor of a n "initialization" test alone. I'm not sure what your rationale behind completely breaking the module's API and test suite could be, but I'd be happy to listen.
From: alex.pavlovic [...] taskforce-1.com
Download (untitled) / with headers
text/plain 1.3k
Both Ricardo and myself have agreed that OO interface be removed. It's clumsy and not needed for this type of module. The test suite you mentioned consists of couple of files that never got added to the distribution, so this may be an error on my part. I will talk to Ricardo further about this and look into bringing the OO interface back as well as some new features. Thank you for your input. On Wed Mar 01 08:01:15 2006, BRICAS wrote: Show quoted text
> Although it is mentioned in the "Changes" file that, from versions
1.63 Show quoted text
> onward, the OO interface has been removed and that we can use an old > version to get it back -- this seriously breaks new installations of > modules that depends on Net::Domain::TLD. > > Case in point: http://use.perl.org/~LTjake/journal/ > > To summarize: Email::Store needs Net::Domain::TLD deep down in the
chain Show quoted text
> (via Email::Valid), but the error returned doesn't make much sense
(due Show quoted text
> to the levels of indirection that I have to deal with in the
application). Show quoted text
> > Also, Ricardo Signes (RJBS) released version 1.62 which included a
great Show quoted text
> test suite which would ensure that future revisions could be
regression Show quoted text
> tested. Following versions completely removed the test suite in
favor of Show quoted text
> a n "initialization" test alone. > > I'm not sure what your rationale behind completely breaking the
module's Show quoted text
> API and test suite could be, but I'd be happy to listen.
From: alex.pavlovic [...] taskforce-1.com
Download (untitled) / with headers
text/plain 554b
On Wed Mar 01 08:01:15 2006, BRICAS wrote: Show quoted text
> I'm not sure what your rationale behind completely breaking the
module's Show quoted text
> API and test suite could be, but I'd be happy to listen.
Also look under the Changes for 1.63, there were significant internal changes made to make some of the things work properly. Code had subroutines that did not work as expected from the documentation. Ricardo has informed me at that time that he started work on something but never got it finished. These features however may become available in the next release.
New version has been uploaded.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.