Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Pod CPAN distribution.

Report information
The Basics
Id: 17892
Status: resolved
Priority: 0/
Queue: Test-Pod

People
Owner: Nobody in particular
Requestors: sisyphus1 [...] optusnet.com.au
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.24
Fixed in: (no value)

Attachments


Subject: t/all_pod_files.t failure on Win32
Download (untitled) / with headers
text/plain 1.1k
D:\Test-Pod-1.24>perl -T t\all_pod_files.t 1..2 ok 1 - use Test::Pod; not ok 2 - Got all the distro files # Failed test 'Got all the distro files' # in t\all_pod_files.t at line 32. # Structures begin differing at: # $got->[0] = 'blib\lib\test\pod.pm' # $expected->[0] = 'blib/lib/test/pod.pm' # Looks like you failed 1 test of 2. Is there in a typo in the assignment to @expected for VMS ? I suspect that: File::Spec->catfile( 't', 'pod', 'good-pod-script.' ), should really be: File::Spec->catfile( 't', 'pod', 'good-pod-script' ), If that suspicion is correct, then all you really need to do is fix that typo and replace: if($^O eq "VMS") with: if($^O eq "VMS" || $^O =~ /MSWin32/i) Otherwise you could give Win32 its own elsif block: elsif($^O =~ /MSWin32/i) { @expected = ( File::Spec->catfile( 'blib', 'lib', 'Test', 'Pod.pm' ), File::Spec->catfile( 't', 'pod', 'good-pod-script' ), File::Spec->catfile( 't', 'pod', 'good.pod' ), File::Spec->catfile( 't', 'pod', 'no_pod.pod' ), ); } I did it by adding that elsif block - which works fine for both my gcc- built and msvc-built perls. I'm using Windows 2000 with perl(s)-5.8.8. Cheers, Rob
From: demerphq [...] gmail.com
Download (untitled) / with headers
text/plain 1021b
On Mon Feb 27 23:02:58 2006, guest wrote: Show quoted text
> D:\Test-Pod-1.24>perl -T t\all_pod_files.t > 1..2 > ok 1 - use Test::Pod; > not ok 2 - Got all the distro files > # Failed test 'Got all the distro files' > # in t\all_pod_files.t at line 32. > # Structures begin differing at: > # $got->[0] = 'blib\lib\test\pod.pm' > # $expected->[0] = 'blib/lib/test/pod.pm' > # Looks like you failed 1 test of 2. >
[...] Show quoted text
> Otherwise you could give Win32 its own elsif block: > > elsif($^O =~ /MSWin32/i) { > @expected = ( > File::Spec->catfile( 'blib', 'lib', 'Test', 'Pod.pm' ), > File::Spec->catfile( 't', 'pod', 'good-pod-script' ), > File::Spec->catfile( 't', 'pod', 'good.pod' ), > File::Spec->catfile( 't', 'pod', 'no_pod.pod' ), > ); > } > > I did it by adding that elsif block - which works fine for both my gcc- > built and msvc-built perls. > > I'm using Windows 2000 with perl(s)-5.8.8.
I did it with s!\\!/!g for @files,@expected; Patch is attached. Yves
--- all_pod_files.t.bak 2006-01-31 21:11:37.000000000 +0100 +++ all_pod_files.t 2006-03-19 22:50:59.268509600 +0100 @@ -29,4 +29,5 @@ } my @files = sort map { lc } all_pod_files( "blib", "t/pod" ); @expected = sort map { lc } @expected; +s!\\!/!g for @files,@expected; is_deeply( \@files, \@expected, "Got all the distro files" );
Fixed in 1.26 which I'm releasing today.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.