Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 17598
Status: resolved
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: attn.steven.kuo [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.05003
Fixed in: (no value)



Subject: Optional test (in t/40resultsetmanager.t) not being skipped
Download (untitled) / with headers
text/plain 541b
Module::Find is listed as a recommended (i.e., optional) module in Build.PL In t/40resultsetmanager.t the $EVAL_ERROR ($@) variable is only checked against one of two require(d) modules: eval { require Class::Inspector; require Module::Find }; if ($@ =~ m{Can.t locate Class/Inspector.pm}) { plan skip_all => "ResultSetManager requires Class::Inspector and Module::Find"; } else { Shouldn't that be if ($@ =~ m{Can.t locate (Class/Inspector.pm|Module/Find.pm)}) { ? This had caused my ./Build install to fail.
Download (untitled) / with headers
text/plain 402b
On Sun Feb 12 14:49:36 2006, guest wrote: Show quoted text
> Module::Find is listed as a recommended (i.e., optional) > module in Build.PL > > In t/40resultsetmanager.t > the $EVAL_ERROR ($@) variable is only checked > against one of two require(d) modules:
Thanks for noticing this. Module::Find was not necessary for the test; the dependency has been removed: http://dev.catalyst.perl.org/trac/bast/changeset/912


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.