Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 17594
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: adamk [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: dynamic_config defaults to an unsafe value
Download (untitled) / with headers
text/plain 1.1k
The dynamic_config option have a default of false, based on the assumption there will be more distributions without dynamic configurations than with them. A better engineering approach to choosing the default would be based on failure modes (what happens when things go wrong) If the default is false and the author omits a dynamic_config option when it is actually dynamic, auto-packagers will be falsely told that the distribution is static when it is not. This leads to shortcutting and bugs because the packager will get the incorrect config for the platform and package it incorrectly. If the default is true and the author omits a dynamic_config option when it is NOT dynamic, auto-packagers will be falsely told that the distribution is dynamic. This leads to inefficiencies due to having to run the Build.PL, but the result will still be correct, and not bugs will occur. The current default will only work with 100% knowledge and attentiveness by authors. This situation will lead to packaging bugs. The default value for dynamic_config should thus be reversed, which is a slightly less efficient, but much more accurate choice, and will not lead to packaging bugs.
Download (untitled) / with headers
text/plain 329b
Agreed, I'll change this in the docs (there's nothing to change in the code). This was actually just a doc error - it's documented correctly in the META.yml spec: http://module-build.sourceforge.net/META-spec-v1.2.html#dynamic_config but we had a brain-o writing the M::B docs, I guess. Thanks for pointing it out. -Ken


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.