Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Devel-Cover CPAN distribution.

Report information
The Basics
Id: 17324
Status: resolved
Priority: 0/
Queue: Devel-Cover

People
Owner: Nobody in particular
Requestors: rafl [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.55
Fixed in: (no value)



Subject: make realclean is broken
Download (untitled) / with headers
text/plain 885b
Hello, I'm about to package Devel::Cover for the Debian GNU/Linux distribution and noticed that the realclean target is broken while I was doing that. It tries to remove directories using $(RM_F), which fails. The following patch uses $(RM_F) to delete files and $(RM_RF) to delete the directories, which fixes the problem for me. --- libdevel-cover-perl-0.55.orig/Makefile.PL +++ libdevel-cover-perl-0.55/Makefile.PL @@ -320,7 +320,10 @@ }, dist => { COMPRESS => "gzip --best --force" }, clean => { FILES => join " ", "t/*", map "$_.version", @versions }, - realclean => { FILES => "lib/Devel/Cover/Inc.pm cover_db t" }, + realclean => { + FILES => "lib/Devel/Cover/Inc.pm", + POSTOP => "\$(RM_RF) cover_db t" + }, depend => { distdir => "@files" }, ); Regards, Flo
CC: undisclosed-recipients: ;
Subject: Re: [rt.cpan.org #17324] make realclean is broken
Date: Fri, 27 Jan 2006 22:11:20 +0100
To: Florian Ragwitz via RT <bug-Devel-Cover [...] rt.cpan.org>
From: Paul Johnson <paul [...] pjcj.net>
Download (untitled) / with headers
text/plain 1.6k
On Fri, Jan 27, 2006 at 02:06:56PM -0500, Florian Ragwitz via RT wrote: Show quoted text
> Hello, > > I'm about to package Devel::Cover for the Debian GNU/Linux distribution
Oooh! Show quoted text
> and noticed that the realclean target is broken while I was doing that. > > It tries to remove directories using $(RM_F), which fails. The following > patch uses $(RM_F) to delete files and $(RM_RF) to delete the > directories, which fixes the problem for me.
Bah. This is a bug in ExtUtils::MakeMaker. It will be fixed in 5.8.8 and 5.9.3, but I supose we should still look out for older installations. So, Show quoted text
> --- libdevel-cover-perl-0.55.orig/Makefile.PL > +++ libdevel-cover-perl-0.55/Makefile.PL > @@ -320,7 +320,10 @@ > }, > dist => { COMPRESS => "gzip --best --force" }, > clean => { FILES => join " ", "t/*", map "$_.version", > @versions }, > - realclean => { FILES => "lib/Devel/Cover/Inc.pm cover_db t" }, > + realclean => { > + FILES => "lib/Devel/Cover/Inc.pm", > + POSTOP => "\$(RM_RF) cover_db t" > + }, > depend => { distdir => "@files" }, > );
Thanks. This will be in the next release. With respect to the packaging, what are your plans with the module dependencies? Storable.pm and Digest::MD5.pm will be in the core, but I don't think there are debian packages for Template.pm, Pod::Coverage.pm, Pod::Coverage::CountParents.pm or Test::Differences.pm. Test::Differences.pm is only used for debugging, so there's no need to worry about that. And the other three are not necessary, but they do provide extra functionality. Oh, and thanks for doing this. -- Paul Johnson - paul@pjcj.net http://www.pjcj.net
Subject: Re: [rt.cpan.org #17324] make realclean is broken
Date: Fri, 27 Jan 2006 22:57:19 +0100
To: "paul [...] pjcj.net via RT" <bug-Devel-Cover [...] rt.cpan.org>
From: Florian Ragwitz <rafl [...] debian.org>
Download (untitled) / with headers
text/plain 987b
On Fri, Jan 27, 2006 at 04:12:24PM -0500, paul@pjcj.net via RT wrote: Show quoted text
> On Fri, Jan 27, 2006 at 02:06:56PM -0500, Florian Ragwitz via RT wrote: > Thanks. This will be in the next release.
Thanks, great. Show quoted text
> With respect to the packaging, what are your plans with the module > dependencies? Storable.pm and Digest::MD5.pm will be in the core, but I > don't think there are debian packages for Template.pm, Pod::Coverage.pm, > Pod::Coverage::CountParents.pm or Test::Differences.pm.
libtemplate-perl 2.14-1 libpod-coverage-perl 0.17-1 libtest-differences-perl 0.47-2 Pod::Coverage::CountParents is included in libpod-coverage-perl. Show quoted text
> Test::Differences.pm is only used for debugging, so there's no need to > worry about that. And the other three are not necessary, but they do > provide extra functionality.
I could suggest libtest-differences-perl and not strictly depend on it. -Flo -- BOFH excuse #146: Communications satellite used by the military for star wars.
Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #17324] make realclean is broken
Date: Fri, 27 Jan 2006 23:15:05 +0100
To: Florian Ragwitz via RT <bug-Devel-Cover [...] rt.cpan.org>
From: Paul Johnson <paul [...] pjcj.net>
Download (untitled) / with headers
text/plain 1016b
On Fri, Jan 27, 2006 at 04:21:10PM -0500, Florian Ragwitz via RT wrote: Show quoted text
> On Fri, Jan 27, 2006 at 04:12:24PM -0500, paul@pjcj.net via RT wrote: >
> > With respect to the packaging, what are your plans with the module > > dependencies? Storable.pm and Digest::MD5.pm will be in the core, but I > > don't think there are debian packages for Template.pm, Pod::Coverage.pm, > > Pod::Coverage::CountParents.pm or Test::Differences.pm.
> > libtemplate-perl 2.14-1 > libpod-coverage-perl 0.17-1 > libtest-differences-perl 0.47-2
Excellent. I've just installed these and everything seems fine. Show quoted text
> Pod::Coverage::CountParents is included in libpod-coverage-perl. >
> > Test::Differences.pm is only used for debugging, so there's no need to > > worry about that. And the other three are not necessary, but they do > > provide extra functionality.
> > I could suggest libtest-differences-perl and not strictly depend on it.
Sounds good to me. Thanks. -- Paul Johnson - paul@pjcj.net http://www.pjcj.net


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.