Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 14086
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: chris+rt [...] chrisdolan.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.27_02
Fixed in: (no value)



Subject: htmlify_pods quitting too early
Download (untitled) / with headers
text/plain 325b
The htmlify_pods() method loops over POD candidates and checks if there is an up to date HTML rendering of that POD file. However, the method mistakenly returns if any html file is up to date instead of skipping to the next candidate. The attached patch against today's CVS (v0.27_02) simply changes the "return" to "next"
Index: lib/Module/Build/Base.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.472 diff -u -b -r1.472 Base.pm --- lib/Module/Build/Base.pm 4 Aug 2005 06:47:34 -0000 1.472 +++ lib/Module/Build/Base.pm 9 Aug 2005 19:33:31 -0000 @@ -2067,7 +2067,7 @@ my $outfile = File::Spec->catfile($fulldir, "${name}.html"); my $infile = File::Spec->abs2rel($pod); - return if $self->up_to_date($infile, $outfile); + next if $self->up_to_date($infile, $outfile); unless ( -d $fulldir ){ File::Path::mkpath($fulldir, 0, 0755)
Thanks, applied. -Ken


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.