Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 14085
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: chris+rt [...] chrisdolan.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.27_02
Fixed in: (no value)



Subject: Erroneously rejecting 'restrictive' license
Download (untitled) / with headers
text/plain 336b
The attached patch against CVS (v0.27_02) corrects a mistake in do_create_metafile() where the license value of undef is incorrectly equated with absense. For the case of "restrictive => undef" this meant that the code emitted "Unknown license type 'restrictive". Also, I fixed the missing trailing single-quote in the error message.
Index: lib/Module/Build/Base.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.472 diff -u -b -r1.472 Base.pm --- lib/Module/Build/Base.pm 4 Aug 2005 06:47:34 -0000 1.472 +++ lib/Module/Build/Base.pm 9 Aug 2005 18:51:10 -0000 @@ -2590,8 +2590,8 @@ $self->log_warn("No license specified, setting license = 'unknown'\n"); $p->{license} = 'unknown'; } - unless ($self->valid_licenses->{ $p->{license} }) { - die "Unknown license type '$p->{license}"; + unless (exists $self->valid_licenses->{ $p->{license} }) { + die "Unknown license type '$p->{license}'"; } # If we're in the distdir, the metafile may exist and be non-writable.
Thanks Chris, I'll apply this when I get home tonight. -Ken


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.