Skip Menu |
 

This queue is for tickets about the File-Finder CPAN distribution.

Report information
The Basics
Id: 13993
Status: open
Priority: 0/
Queue: File-Finder

People
Owner: MERLYN [...] cpan.org
Requestors: CHORNY [...] cpan.org
tshinnic [...] io.com
Cc: PLICEASE [...] cpan.org
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.53
Fixed in: (no value)

Attachments


Subject: Cannot install under Win32 Perl (ActiveState)
File::Finder will not install under ActiveState Win32 Perl due to unguarded reliance on 'get(pw|gr)ent' APIs. The tests fail trying to test the File::Finder::Steps features. FF::Steps tries to initialize itself with values from getpwent and getgrent upon any use of the methods user(), nouser(), group(), nogroup(), and ls(). These two APIs are not available under Win32 Perls. This may be why ActiveState has a ppm only for release 0.01. You would know better which way of testing for Win32 Perls is best. The included tar.gz file shows fixes using testing of $Config::Config{d_xxxxxx} and also testing against $^O . The included patches use $^O as better due to not dragging in Config. They are workaround quality only, and you can undoubtedly come up with better. Patches are needed in both the Steps.pm module and the test 05-steps.t s for Steps features. With these workaround patches File-Finder will install under Win32 Perl. You may want to also add a note to the pod saying that the above-named Steps methods are not available under Win32.
Download file-finder-0.53.win32.patch.tar.gz
application/x-gzip-compressed 8.6k

Message body not shown because it is not plain text.

Subject: Cannot install under Win32 Perl
Download (untitled) / with headers
text/plain 1.3k
On Tue Aug 02 17:32:21 2005, guest wrote: Show quoted text
> File::Finder will not install under ActiveState Win32 Perl due to > unguarded reliance on 'get(pw|gr)ent' APIs. The tests fail trying > to test the File::Finder::Steps features. > > FF::Steps tries to initialize itself with values from getpwent and > getgrent upon any use of the methods user(), nouser(), group(), > nogroup(), and ls(). These two APIs are not available under Win32 > Perls. This may be why ActiveState has a ppm only for release > 0.01. > > You would know better which way of testing for Win32 Perls is best. > The included tar.gz file shows fixes using testing of > $Config::Config{d_xxxxxx} and also testing against $^O . The > included patches use $^O as better due to not dragging in Config. > They are workaround quality only, and you can undoubtedly come up > with better. > > Patches are needed in both the Steps.pm module and the test 05-steps.t > s for Steps features. With these workaround patches File-Finder > will install under Win32 Perl. > > You may want to also add a note to the pod saying that the above-named > Steps methods are not available under Win32.
This applies to Strawberry, too, btw, so bumping. (File::Finder is used by Test::Fixme, which I would like to be able to use in the Perl::Dist::* modules as a test without having to force File::Finder's installation.)
CC: undisclosed-recipients:;
Subject: Re: [rt.cpan.org #13993] Cannot install under Win32 Perl
Date: Tue, 30 Mar 2010 11:53:20 -0700
To: bug-File-Finder [...] rt.cpan.org
From: merlyn [...] stonehenge.com (Randal L. Schwartz)
Download (untitled) / with headers
text/plain 739b
Show quoted text
>>>>> "Curtis" == Curtis Jewell via RT <bug-File-Finder@rt.cpan.org> writes:
Show quoted text
Curtis> This applies to Strawberry, too, btw, so bumping.
Show quoted text
Curtis> (File::Finder is used by Test::Fixme, which I would like to be able to Curtis> use in the Perl::Dist::* modules as a test without having to force Curtis> File::Finder's installation.)
Yeah, sorry. Haven't had time to look at this yet, and I don't have access to any windows machines. Patches welcome! -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 <merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/> Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc. See http://methodsandmessages.vox.com/ for Smalltalk and Seaside discussion
Download (untitled) / with headers
text/plain 240b
On Tue Mar 30 14:53:48 2010, merlyn@stonehenge.com wrote: Show quoted text
> Yeah, sorry. Haven't had time to look at this yet, and I don't > have access to any windows machines. Patches welcome!
Patch attached. -- Alexandr Ciornii, http://chorny.net
Subject: 05-steps.t.patch
Download 05-steps.t.patch
text/x-diff 643b
--- 05-steps.t.dist 2004-10-07 09:04:12.000000000 +0300 +++ 05-steps.t 2012-03-30 21:42:37.843750000 +0300 @@ -65,6 +65,8 @@ [fin(sub { -f }, '.')], 'all files even after messing with _ pseudo handle'); +SKIP: { +skip 'user/nouser/etc. not supported on Windows', 8 if $^O eq 'MSWin32'; is_deeply([File::Finder->user($<)->in(qw(.))], [fin(sub { -o }, '.')], 'owned'); @@ -96,6 +98,7 @@ is_deeply([File::Finder->not->nogroup->in(qw(.))], [fin(sub { defined getgrgid((stat)[5]) }, '.')], 'not nogroup'); +} is_deeply([File::Finder->links('-2')->in(qw(.))], [fin(sub { (stat)[3] < 2 }, '.')],
Download (untitled) / with headers
text/plain 364b
On Fri Mar 30 14:45:09 2012, CHORNY wrote: Show quoted text
> On Tue Mar 30 14:53:48 2010, merlyn@stonehenge.com wrote: >
> > Yeah, sorry. Haven't had time to look at this yet, and I don't > > have access to any windows machines. Patches welcome!
> > Patch attached. >
The patch provided by CHORNY looks good to me, how about a release? Please let me know if I can help out.
CC: undisclosed-recipients:;
Subject: Re: [rt.cpan.org #13993] Cannot install under Win32 Perl (ActiveState)
Date: Thu, 25 Oct 2018 18:41:20 -0700
To: "Graham Ollis via RT" <bug-File-Finder [...] rt.cpan.org>
From: merlyn [...] stonehenge.com (Randal L. Schwartz)
Download (untitled) / with headers
text/plain 540b
Show quoted text
>>>>> "Graham" == Graham Ollis via RT <bug-File-Finder@rt.cpan.org> writes:
Show quoted text
Graham> The patch provided by CHORNY looks good to me, how about a release? Please Graham> let me know if I can help out.
It's on Github... a pull request would be appreciated. -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 <merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/> Perl/Unix/Dart consulting, Technical writing, Comedy, etc. etc. Still trying to think of something clever for the fourth line of this .sig
Download (untitled) / with headers
text/plain 913b
On Thu Oct 25 21:45:31 2018, merlyn@stonehenge.com wrote: Show quoted text
> >>>>> "Graham" == Graham Ollis via RT <bug-File-Finder@rt.cpan.org> > >>>>> writes:
>
> Graham> The patch provided by CHORNY looks good to me, how about a > Graham> release? Please > Graham> let me know if I can help out.
> > It's on Github... a pull request would be appreciated.
Here is CHRONY's fix + an additional fix that I needed to get it working: https://github.com/RandalSchwartz/perl-module-file-finder/pull/3 Please also consider merging: https://github.com/RandalSchwartz/perl-module-file-finder/pull/1 I did actually do a search on github for this repository before my comment earlier but wasn't able to find it immediately. When you said it was on github I did a more extensive search, but if the metadata has the github repository then there will be links directly from metacpan which will make it much easier for others to find.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.