Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Software-License CPAN distribution.

Report information
The Basics
Id:
134890
Status:
open
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
AsDaGo [...] posteo.net
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



From: "Asher Gordon" <AsDaGo@posteo.net>
Subject: [PATCH] Fix deprecated SPDX identifiers for AGPL_3, LGPL_2_1, and LGPL_3_0.
To: bug-Software-License@rt.cpan.org
Date: Fri, 02 Apr 2021 17:13:00 -0400
Hello, Some of the licenses still have deprecated SPDX identifiers (without the "-only" suffix). The attached patch fixes that, and patches the test file to test for the correct identifiers:
From 520d5e4ea8a36df840be72314ab434bd24397dc9 Mon Sep 17 00:00:00 2001 From: Asher Gordon <AsDaGo@posteo.net> Date: Fri, 2 Apr 2021 16:04:15 -0400 Subject: [PATCH] Fix deprecated SPDX identifiers for AGPL_3, LGPL_2_1, and LGPL_3_0. --- lib/Software/License/AGPL_3.pm | 2 +- lib/Software/License/LGPL_2_1.pm | 2 +- lib/Software/License/LGPL_3_0.pm | 2 +- t/spdx-expression.t | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) mode change 100644 => 100755 t/spdx-expression.t diff --git a/lib/Software/License/AGPL_3.pm b/lib/Software/License/AGPL_3.pm index fc5e106..f599769 100644 --- a/lib/Software/License/AGPL_3.pm +++ b/lib/Software/License/AGPL_3.pm @@ -10,7 +10,7 @@ sub url { 'http://www.gnu.org/licenses/agpl-3.0.txt' } sub meta_name { 'open_source' } sub meta2_name { 'agpl_3' } -sub spdx_expression { 'AGPL-3.0' } +sub spdx_expression { 'AGPL-3.0-only' } 1; __DATA__ diff --git a/lib/Software/License/LGPL_2_1.pm b/lib/Software/License/LGPL_2_1.pm index f6de2ac..d570c59 100644 --- a/lib/Software/License/LGPL_2_1.pm +++ b/lib/Software/License/LGPL_2_1.pm @@ -9,7 +9,7 @@ sub name { 'The GNU Lesser General Public License, Version 2.1, February 1999' } sub url { 'http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt' } sub meta_name { 'lgpl' } sub meta2_name { 'lgpl_2_1' } -sub spdx_expression { 'LGPL-2.1' } +sub spdx_expression { 'LGPL-2.1-only' } 1; __DATA__ diff --git a/lib/Software/License/LGPL_3_0.pm b/lib/Software/License/LGPL_3_0.pm index 1b102ff..3ec352d 100644 --- a/lib/Software/License/LGPL_3_0.pm +++ b/lib/Software/License/LGPL_3_0.pm @@ -11,7 +11,7 @@ sub name { 'The GNU Lesser General Public License, Version 3, June 2007' } sub url { 'http://www.gnu.org/licenses/lgpl-3.0.txt' } sub meta_name { 'lgpl' } sub meta2_name { 'lgpl_3_0' } -sub spdx_expression { 'LGPL-3.0' } +sub spdx_expression { 'LGPL-3.0-only' } sub fulltext { my ($self) = @_; diff --git a/t/spdx-expression.t b/t/spdx-expression.t old mode 100644 new mode 100755 index 38d4466..1e7ea67 --- a/t/spdx-expression.t +++ b/t/spdx-expression.t @@ -32,7 +32,7 @@ use Software::License::QPL_1_0; use Software::License::Zlib; is (scalar(Software::License::AGPL_3->spdx_expression()), - 'AGPL-3.0', + 'AGPL-3.0-only', "AGPL_3->spdx_expression() is OK." ); @@ -107,12 +107,12 @@ is (scalar(Software::License::GPL_3->spdx_expression()), ); is (scalar(Software::License::LGPL_2_1->spdx_expression()), - 'LGPL-2.1', + 'LGPL-2.1-only', "LGPL_2_1->spdx_expression() is OK." ); is (scalar(Software::License::LGPL_3_0->spdx_expression()), - 'LGPL-3.0', + 'LGPL-3.0-only', "LGPL_3_0->spdx_expression() is OK." ); -- 2.30.2
Also related is the bug I reported for Software::License::or_later, which should override spdx_identifier(): https://rt.cpan.org/Public/Bug/Display.html?id=134889 Thanks, Asher P.S. I am aware that the preferred tracker is on GitHub, but unfortunately it seems that you need an account to post there. I don't want to create a GitHub account right now, so I'm posting here instead. Sorry for any inconvenience. You may also consider moving to a better software forge; see here: https://www.gnu.org/software/repo-criteria-evaluation.html -- <knghtbrd> eek, not another one... <knghtbrd> Seems ever developer and their mother now has a random signature using irc quotes ... <knghtbrd> WHAT HAVE I STARTED HERE?? -------- I prefer to send and receive mail encrypted. Please send me your public key, and if you do not have my public key, please let me know. Thanks. GPG fingerprint: 38F3 975C D173 4037 B397 8095 D4C9 C4FC 5460 8E68

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #134890] [PATCH] Fix deprecated SPDX identifiers for AGPL_3, LGPL_2_1, and LGPL_3_0.
Date: Sun, 4 Apr 2021 01:14:14 +0200
From: "Leon Timmermans" <fawaka@gmail.com>
To: bug-Software-License@rt.cpan.org
On Fri, Apr 2, 2021 at 11:13 PM Asher Gordon via RT <bug-Software-License@rt.cpan.org> wrote:
Show quoted text
> Hello, > > Some of the licenses still have deprecated SPDX identifiers (without the > "-only" suffix). The attached patch fixes that, and patches the test > file to test for the correct identifiers: > > Also related is the bug I reported for Software::License::or_later, > which should override spdx_identifier(): > https://rt.cpan.org/Public/Bug/Display.html?id=134889
Your patch makes sense to me.
Show quoted text
> P.S. I am aware that the preferred tracker is on GitHub, but > unfortunately it seems that you need an account to post there. I don't > want to create a GitHub account right now, so I'm posting here > instead. Sorry for any inconvenience. You may also consider moving to a > better software forge; see here: > https://www.gnu.org/software/repo-criteria-evaluation.html
Luckily for you, rt.cpan.org narrowly avoided being scrapped last month ;-) Leon
To: bug-Software-License@rt.cpan.org
From: "Asher Gordon" <AsDaGo@posteo.net>
Subject: Re: [rt.cpan.org #134890] [PATCH] Fix deprecated SPDX identifiers for AGPL_3, LGPL_2_1, and LGPL_3_0.
Date: Sun, 04 Apr 2021 13:28:00 -0400
"Leon Timmermans via RT" <bug-Software-License@rt.cpan.org> writes:
Show quoted text
> Your patch makes sense to me.
Ok, cool.
Show quoted text
> Luckily for you, rt.cpan.org narrowly avoided being scrapped last > month ;-)
Yeah, I heard about that! Glad they decided to keep it. Asher -- ...very few phenomena can pull someone out of Deep Hack Mode, with two noted exceptions: being struck by lightning, or worse, your *computer* being struck by lightning. -- Matt Welsh -------- I prefer to send and receive mail encrypted. Please send me your public key, and if you do not have my public key, please let me know. Thanks. GPG fingerprint: 38F3 975C D173 4037 B397 8095 D4C9 C4FC 5460 8E68

Message body not shown because it is not plain text.



This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.