This queue is for tickets about the XS-Parse-Sublike CPAN distribution.

Report information
The Basics
Id:
134012
Status:
resolved
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
TONYC [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
0.11



Subject: signature error message change breaks XS::Parse::Sublike test
The error message reported for mismatched signature parameter counts now includes the expected and actual parameter counts (0f14f058b16). This breaks t/02func-signatures.t This was reported against perl as https://github.com/Perl/perl5/issues/18459 # Failed test 'Exception thrown from empty signature validation failure' # at t/02func-signatures.t line 60. # 'Too many arguments for subroutine 'main::noparams' (got 3; expected 0) at t/02func-signatures.t line 59. # ' # doesn't match '(?^:^Too many arguments for subroutine 'main::noparams' at )' # Looks like you failed 1 test of 9. t/02func-signatures.t ......... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests
On Wed Jan 06 22:42:04 2021, TONYC wrote:
Show quoted text
> The error message reported for mismatched signature parameter counts > now includes the expected and actual parameter counts (0f14f058b16). > > This breaks t/02func-signatures.t > > This was reported against perl as > https://github.com/Perl/perl5/issues/18459 > > # Failed test 'Exception thrown from empty signature validation > failure' > # at t/02func-signatures.t line 60. > # 'Too many arguments for subroutine > 'main::noparams' (got 3; expected 0) at t/02func-signatures.t line 59. > # ' > # doesn't match '(?^:^Too many arguments for subroutine > 'main::noparams' at )' > # Looks like you failed 1 test of 9. > t/02func-signatures.t ......... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/9 subtests
Ah yes; ever the danger with asserting on exact error messages during unit tests. I'll take a look. -- Paul Evans
On Thu Jan 07 05:53:40 2021, PEVANS wrote:
Show quoted text
> Ah yes; ever the danger with asserting on exact error messages during > unit tests. > > I'll take a look.
For now I'll make that part of the regexp optional, but if the message in Perl changes any more I might have to adjust the way I run that test. Fixed in version 0.11. -- Paul Evans


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.