Skip Menu |
 

This queue is for tickets about the Bit-Vector CPAN distribution.

Report information
The Basics
Id: 133119
Status: open
Priority: 0/
Queue: Bit-Vector

People
Owner: Nobody in particular
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 7.4
Fixed in: (no value)

Attachments
Use-ppport.h-for-version-comparison-logic-in-XS.patch



Subject: XS Version logic breaks if perl's major version > 5
Download (untitled) / with headers
text/plain 238b
Hi, This module fails to build once the perl version goes from 5 to 7. Devel::PPPort now provides proper version comparison logic so you don't need to to roll your own. I am providing you with a patch to fix this. Hope that helps! Todd
Here you go.
Subject: Use-ppport.h-for-version-comparison-logic-in-XS.patch

Message body is not shown because it is too large.

Download (untitled) / with headers
text/plain 331b
ppport.h shouldn't be included with the patch, as this implies it will never be upgraded again when Devel::PPPort increases. Instead, it should be generated in the normal way via Makefile.PL in author mode: if (!-f 'META.yml' or -d '.git') { require Devel::PPPort; Devel::PPPort->VERSION(3.58); Devel::PPPort::WriteFile(); }
Download (untitled) / with headers
text/plain 527b
On 2020-08-05 17:00:11, ETHER wrote: Show quoted text
> ppport.h shouldn't be included with the patch, as this implies it will > never be upgraded again when Devel::PPPort increases. Instead, it > should be generated in the normal way via Makefile.PL in author mode: > > if (!-f 'META.yml' or -d '.git') { > require Devel::PPPort; > Devel::PPPort->VERSION(3.58); > Devel::PPPort::WriteFile(); > }
This patch isn't correct either, since Devel::PPPort has not yet been released with the appropriate macros. Please wait until that occurs.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.