Skip Menu |
 

This queue is for tickets about the Compress-Raw-Zlib CPAN distribution.

Report information
The Basics
Id: 132734
Status: resolved
Priority: 0/
Queue: Compress-Raw-Zlib

People
Owner: Nobody in particular
Requestors: p5p [...] yhbt.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.094

Attachments
0001-fix-RT-132734.patch
0001-show-failing-test-case-with-AppendOutput-and-OOK-sca.patch



Subject: [PATCH] show failing test case with -AppendOutput and OOK scalars
Date: Fri, 29 May 2020 07:26:37 +0000
To: bug-Compress-Raw-Zlib [...] rt.cpan.org
From: Eric Wong <p5p [...] yhbt.net>
Download (untitled) / with headers
text/plain 173b
I noticed ->inflate using AppendOutput and an OOK scalar destination fails in my application. Attached is a test case reproducing the bug. Thanks for Compress::Raw::Zlib!

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 513b
On Fri May 29 03:32:44 2020, p5p@yhbt.net wrote: Show quoted text
> I noticed ->inflate using AppendOutput and an OOK scalar > destination fails in my application. > > Attached is a test case reproducing the bug. Thanks for > Compress::Raw::Zlib!
Hey Eric, thanks for the bug report. when I comment out the workaround section of the patch I get this # Failed test (t/02zlib.t at line 772) # got: '. I.m a HAL 9000 computer' # expected: '. I am a HAL 9000 computer' Does that match with what you are seeing?
Subject: Re: [rt.cpan.org #132734] [PATCH] show failing test case with -AppendOutput and OOK scalars
Date: Fri, 29 May 2020 08:01:18 +0000
To: Paul Marquess via RT <bug-Compress-Raw-Zlib [...] rt.cpan.org>
From: Eric Wong <p5p [...] yhbt.net>
Download (untitled) / with headers
text/plain 819b
Paul Marquess via RT <bug-Compress-Raw-Zlib@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=132734 > > > On Fri May 29 03:32:44 2020, p5p@yhbt.net wrote:
> > I noticed ->inflate using AppendOutput and an OOK scalar > > destination fails in my application. > > > > Attached is a test case reproducing the bug. Thanks for > > Compress::Raw::Zlib!
> > > Hey Eric, > > thanks for the bug report. when I comment out the workaround section of the patch I get this > > # Failed test (t/02zlib.t at line 772) > # got: '. I.m a HAL 9000 computer' > # expected: '. I am a HAL 9000 computer' > > Does that match with what you are seeing?
Hi Paul, Yes, sorry, for not making that clear. I actually dug around and think I figured out a fix (still learning perlguts). See attached.

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 1.1k
On Fri May 29 04:01:24 2020, p5p@yhbt.net wrote: Show quoted text
> Paul Marquess via RT <bug-Compress-Raw-Zlib@rt.cpan.org> wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=132734 > > > > > On Fri May 29 03:32:44 2020, p5p@yhbt.net wrote:
> > > I noticed ->inflate using AppendOutput and an OOK scalar > > > destination fails in my application. > > > > > > Attached is a test case reproducing the bug. Thanks for > > > Compress::Raw::Zlib!
> > > > > > Hey Eric, > > > > thanks for the bug report. when I comment out the workaround section > > of the patch I get this > > > > # Failed test (t/02zlib.t at line 772) > > # got: '. I.m a HAL 9000 computer' > > # expected: '. I am a HAL 9000 computer' > > > > Does that match with what you are seeing?
> > Hi Paul, > > Yes, sorry, for not making that clear. I actually dug around > and think I figured out a fix (still learning perlguts). > See attached.
No worries and thanks for the excellent bug report. A self-contained test to reproduce the issue and a proposed fix. Brilliant! The thing that concerns me is that this bug has been lurking for years! cheers Paul
GitHub ticket for this issue is https://github.com/pmqs/IO-Compress/issues/18
Download (untitled) / with headers
text/plain 208b
On Fri May 29 17:22:09 2020, PMQS wrote: Show quoted text
> GitHub ticket for this issue is https://github.com/pmqs/IO- > Compress/issues/18
oops - wrong ticket - should be https://github.com/pmqs/Compress-Raw-Zlib/issues/3


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.