Skip Menu |
 

This queue is for tickets about the HTTP-Date CPAN distribution.

Report information
The Basics
Id: 130875
Status: resolved
Priority: 0/
Queue: HTTP-Date

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 6.02
Fixed in: (no value)



Subject: Test fails three days after DST switch
Download (untitled) / with headers
text/plain 444b
Test number 95 fails three days after a DST switch to normal date. This can be reproduced with the help of Time::Fake: $ env TZ=Europe/Berlin perl5.28.1 -MTime::Fake=1572399180 -Mblib t/date.t ... not ok 95 # Test 95 got: "1572136380" (t/date.t at line 89) # Expected: "1572139980" # t/date.t line 89 is: ok($t, $time); ... Here's a related CPAN Testers report: http://www.cpantesters.org/cpan/report/e487ea72-fae1-11e9-aff9-042b1f24ea8f
Download (untitled) / with headers
text/plain 653b
On Sat Nov 02 05:30:31 2019, SREZIC wrote: Show quoted text
> Test number 95 fails three days after a DST switch to normal date. > This can be reproduced with the help of Time::Fake: > > $ env TZ=Europe/Berlin perl5.28.1 -MTime::Fake=1572399180 -Mblib > t/date.t > ... > not ok 95 > # Test 95 got: "1572136380" (t/date.t at line 89) > # Expected: "1572139980" > # t/date.t line 89 is: ok($t, $time); > ... > > Here's a related CPAN Testers report: > http://www.cpantesters.org/cpan/report/e487ea72-fae1-11e9-aff9- > 042b1f24ea8f
Does this patch fix the issue? https://github.com/gisle/http-date/pull/4/files If so, I can look at getting a new release out soon.
Download (untitled) / with headers
text/plain 801b
On 2019-11-03 12:00:29, OALDERS wrote: Show quoted text
> On Sat Nov 02 05:30:31 2019, SREZIC wrote:
> > Test number 95 fails three days after a DST switch to normal date. > > This can be reproduced with the help of Time::Fake: > > > > $ env TZ=Europe/Berlin perl5.28.1 -MTime::Fake=1572399180 -Mblib > > t/date.t > > ... > > not ok 95 > > # Test 95 got: "1572136380" (t/date.t at line 89) > > # Expected: "1572139980" > > # t/date.t line 89 is: ok($t, $time); > > ... > > > > Here's a related CPAN Testers report: > > http://www.cpantesters.org/cpan/report/e487ea72-fae1-11e9-aff9- > > 042b1f24ea8f
> > Does this patch fix the issue? https://github.com/gisle/http- > date/pull/4/files If so, I can look at getting a new release out > soon.
Looks good to me, at least it passes with the Time::Fake hack above.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.