Skip Menu |
 

This queue is for tickets about the TermReadKey CPAN distribution.

Report information
The Basics
Id: 130445
Status: open
Priority: 0/
Queue: TermReadKey

People
Owner: Nobody in particular
Requestors: KUERBIS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Win32 term width
Download (untitled) / with headers
text/plain 206b
ReadKey.xs - lines 505,506: if (retheight) *retheight = info.srWindow.Bottom - info.srWindow.Top; # 1 Top # 2 # 3 # 4 # 5 Bottom Should this be "Bottom + 1 - Top" instead of "Bottom - Top"?
Subject: Re: [rt.cpan.org #130445] Win32 term width
Date: Thu, 19 Sep 2019 14:53:14 +0100
To: bug-TermReadKey [...] rt.cpan.org
From: Jonathan Stowe <jonathan.stowe [...] gmail.com>
Download (untitled) / with headers
text/plain 992b
Hi, I've copied this into https://github.com/jonathanstowe/TermReadKey/issues/32 on GitHub as that is easier to manage for me. Unfortunately I'm not in a position to test on Windows at the moment, but if you could send a pull request on Github I'll merge it as long as it passes the tests on the platforms I can test. Thanks. On Wed, 2019-09-04 at 03:48 -0400, Matthäus Kiem via RT wrote: Show quoted text
> Wed Sep 04 03:48:20 2019: Request 130445 was acted upon. > Transaction: Ticket created by KUERBIS > Queue: TermReadKey > Subject: Win32 term width > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: KUERBIS@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=130445 > > > > > ReadKey.xs - lines 505,506: > > if (retheight) > *retheight = info.srWindow.Bottom - info.srWindow.Top; > > # 1 Top > # 2 > # 3 > # 4 > # 5 Bottom > > Should this be "Bottom + 1 - Top" instead of "Bottom - Top"?
Subject: Re: [rt.cpan.org #130445] Win32 term width
Date: Fri, 20 Sep 2019 11:49:59 +0200
To: bug-TermReadKey [...] rt.cpan.org
From: Matthäus Kiem <matthaeuskiem [...] gmail.com>
Download (untitled) / with headers
text/plain 1.1k
Hi, I've submitted a patch. Am 19.09.19 um 15:53 schrieb Jonathan Stowe via RT: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=130445 > > > Hi, > I've copied this into > https://github.com/jonathanstowe/TermReadKey/issues/32 on GitHub as > that is easier to manage for me. > > Unfortunately I'm not in a position to test on Windows at the moment, > but if you could send a pull request on Github I'll merge it as long as > it passes the tests on the platforms I can test. > > Thanks. > > On Wed, 2019-09-04 at 03:48 -0400, Matthäus Kiem via RT wrote:
>> Wed Sep 04 03:48:20 2019: Request 130445 was acted upon. >> Transaction: Ticket created by KUERBIS >> Queue: TermReadKey >> Subject: Win32 term width >> Broken in: (no value) >> Severity: (no value) >> Owner: Nobody >> Requestors: KUERBIS@cpan.org >> Status: new >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=130445 > >> >> >> >> ReadKey.xs - lines 505,506: >> >> if (retheight) >> *retheight = info.srWindow.Bottom - info.srWindow.Top; >> >> # 1 Top >> # 2 >> # 3 >> # 4 >> # 5 Bottom >> >> Should this be "Bottom + 1 - Top" instead of "Bottom - Top"?


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.