Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the HTML-FormatText-WithLinks-AndTables CPAN distribution.

Report information
The Basics
Id: 130301
Status: new
Priority: 0/
Queue: HTML-FormatText-WithLinks-AndTables

People
Owner: Nobody in particular
Requestors: fish [...] guralp.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: patch to handle nested tables
Date: Wed, 14 Aug 2019 16:34:32 +0000
To: "bug-HTML-FormatText-WithLinks-AndTables [...] rt.cpan.org" <bug-HTML-FormatText-WithLinks-AndTables [...] rt.cpan.org>
From: Fish <fish [...] guralp.com>
Download (untitled) / with headers
text/plain 1.8k
Hi, I needed HTML::FormatText::WithLinks::AndTables to cope with nested tables, so I replaced some calls to HTML::Element::look_down() with calls to a new method, safe_look_down() which will not descend past a table. Apologies: I'm new to submitting patches and such but I've attached a patch-file created using diff -u old new - I hope that this is useful. I've attached my new version as well in case that is more useful. I also think that I've managed to put my version through the test suite that CPAN downloads alongside your module. I performed a get, a make and a test, edited the version under ~/.cpan and then ran another test: all passed. In addition, I've pushed several hundred real-world documents through without seeing any new issues emerging. Please let me know if I've omitted anything you need. I'd also be very grateful to hear any comments or criticism you may have. Yours, -- fish Güralp Systems Ltd Customer Support Manager/Scientific Author [http://www.guralp.com/documents/guralp-email-logo.png] About this email Confidentiality Notice: This email is confidential and may be legally privileged. It is intended only for use of the named recipient. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please notify us immediately and then delete this document. Internet communications are not secure and therefore Güralp Systems Limited does not accept legal responsibility for the contents of this message. If you do not wish to correspond by email, please write or telephone us instead. Guralp Systems Limited is a company registered in England and Wales. Registration number: 2199239. Registered Office: 3 Midas House, Calleva Park, Aldermaston, Reading, RG7 8EA Güralp Systems LTD<http://guralp.com>
Download AndTables.diff
text/x-diff 2.8k

Message body is not shown because sender requested not to inline it.

Download AndTables_v0.08.pm
text/x-perl 13.5k

Message body is not shown because sender requested not to inline it.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.