Skip Menu |
 

This queue is for tickets about the Devel-Leak-Object CPAN distribution.

Report information
The Basics
Id: 12942
Status: new
Priority: 0/
Queue: Devel-Leak-Object

People
Owner: Nobody in particular
Requestors: mca+cpanrt [...] sanger.ac.uk
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.02
Fixed in: (no value)



Subject: Fix for objects which override stringify
Download (untitled) / with headers
text/plain 443b
The attached (quick'n'dirty) patch fixes the problem you get with objects such as those in Test::Unit, where the stringify overload stops the parsing of the "$obj" working correctly: Not passed an object at /usr/local/lib/perl5/site_perl/5.8.0/Test/Unit/Assertion/Boolean.pm line 20 Use of uninitialized value in exists at /nfs/team71/psg/mca/cvswork-badger/AniTrack/testlib/Devel/Leak/Object.pm line 105. Requires Scalar::Util. Thanks,
Download DLO.diff
text/x-diff 1.3k
--- Devel/Leak/Object.pm~ 2004-09-20 06:53:39.000000000 +0100 +++ Devel/Leak/Object.pm 2005-05-24 15:11:18.000000000 +0100 @@ -74,6 +74,7 @@ our %destroy_orig; use Data::Dumper; +use Scalar::Util; sub import { for my $i (0..$#_) { @@ -97,11 +98,7 @@ { my $obj = shift; - my ($class,$type,$addr) = "$obj" =~ /^ - ((?:\w|\:\:)+) # Stringification has pkg name - =(ARRAY|HASH|SCALAR|GLOB|CODE) # type - \((0x[0-9a-f]+)\) # and address - /x or carp "Not passed an object"; + my ($class,$type,$addr) = _getinfo($obj); if (exists $tracked{$addr}) { # rebless of tracked object $objcount{$tracked{$addr}}--; } @@ -125,13 +122,18 @@ } } +sub _getinfo { + my $obj = shift; + my @info = (Scalar::Util::blessed($obj), + sprintf("0x%X", Scalar::Util::refaddr($obj)), + Scalar::Util::reftype($obj)); + carp "Not passed an object" unless defined $info[0]; + return @info; +} + sub _DESTROY_stub { my ($obj) = @_; - my ($class,$type,$addr) = "$obj" =~ /^ - ((?:\w|\:\:)+) # Stringification has pkg name - =(ARRAY|HASH|SCALAR|GLOB|CODE) # type - \((0x[0-9a-f]+)\) # and address - /x or carp "Not passed an object"; + my ($class,$type,$addr) = _getinfo($obj); if (exists($objcount{$class})) { $objcount{$class}--; warn "Object count for $class negative ($objcount{$class})\n"
Subject: Fix(2) for objects which override stringify
From: mca+cpanrt [...] sanger.ac.uk
Download (untitled) / with headers
text/plain 581b
[guest - Tue May 24 10:12:25 2005]: Show quoted text
> The attached (quick'n'dirty) patch fixes the problem you get with > objects such as those in Test::Unit,
That patch was broken - reftype and refaddr were transposed so tracking was b0rk. Attached patch replaces the first one, adds a few extra features. See also http://www.perlmonks.org/?node_id=150796 for a "what's the REFCNT of this object?" thread. I'll probably do a little more work on this, but I also suspect that once I get answers to my questions I'll have to abandon the patching at whatever point I reach. Hope that's useful,
Download DLO2.diff
text/x-diff 2.8k
--- Object.pm~~ 2005-05-25 10:58:01.000000000 +0100 +++ Object.pm 2005-05-25 17:31:47.000000000 +0100 @@ -69,11 +69,14 @@ use Carp; -our %objcount; -our %tracked; -our %destroy_orig; +our %objcount; # key = class, value = running total of outstanding objects +our %tracked; # key = address, value = class +our %obj_seen; # key = address, value = weakened ref to object +our %destroy_orig; # key = package, value = original DESTROY CODE use Data::Dumper; +use Scalar::Util qw(weaken blessed reftype refaddr); +use B 'svref_2object'; sub import { for my $i (0..$#_) { @@ -88,6 +91,7 @@ sub bless { my ($ref,$pkg) = @_; + $pkg = (caller)[0] unless defined $pkg; # a call of "bless {}", e.g. in DBI my $obj = CORE::bless($ref,$pkg); Devel::Leak::Object::track($obj); $obj; @@ -97,23 +101,24 @@ { my $obj = shift; - my ($class,$type,$addr) = "$obj" =~ /^ - ((?:\w|\:\:)+) # Stringification has pkg name - =(ARRAY|HASH|SCALAR|GLOB|CODE) # type - \((0x[0-9a-f]+)\) # and address - /x or carp "Not passed an object"; + my ($class,$type,$addr) = _getinfo($obj); if (exists $tracked{$addr}) { # rebless of tracked object $objcount{$tracked{$addr}}--; } $tracked{$addr} = $class; + + $obj_seen{$addr} = $obj; + weaken($obj_seen{$addr}); + if (!exists $objcount{$class}) { no strict 'refs'; if ((exists ${$class.'::'}{DESTROY}) && *{$class.'::DESTROY'}{CODE}) { $destroy_orig{$class} = \&{$class.'::DESTROY'}; } - *{$class.'::DESTROY'} = \&_DESTROY_stub; ${$class.'::DESTROY_stubbed'} = 1; + no warnings; + *{$class.'::DESTROY'} = \&_DESTROY_stub; } $objcount{$class}++; } @@ -125,13 +130,43 @@ } } +sub get_status () { + return %objcount; +} + +sub get_seen () { + my %collect; # key = class, value = list of outstanding objects + foreach my $addr (keys %obj_seen) { + my $obj = $obj_seen{$addr}; + if (!defined $obj) { + # Weak ref has become undef. Just tidy up and move on. + delete $obj_seen{$addr}; + next; + } + my ($class,$type,$addr) = _getinfo($obj); + my $list = $collect{$class} ||= []; + push @$list, $obj; + } + return %collect; +} + +sub get_refinfo ($) { + my $bsv = svref_2object(shift); + return (ref($bsv), $bsv->REFCNT); +} + +sub _getinfo { + my $obj = shift; + my @info = (blessed($obj), + reftype($obj), + sprintf("0x%X", refaddr($obj))); + carp "Not passed an object" unless defined $info[0]; + return @info; +} + sub _DESTROY_stub { my ($obj) = @_; - my ($class,$type,$addr) = "$obj" =~ /^ - ((?:\w|\:\:)+) # Stringification has pkg name - =(ARRAY|HASH|SCALAR|GLOB|CODE) # type - \((0x[0-9a-f]+)\) # and address - /x or carp "Not passed an object"; + my ($class,$type,$addr) = _getinfo($obj); if (exists($objcount{$class})) { $objcount{$class}--; warn "Object count for $class negative ($objcount{$class})\n"
From: 6bed-rgew [...] spamex.com
To: <bug-Devel-Leak-Object [...] rt.cpan.org>
Subject: Re: [cpan #12942] Fix(2) for objects which override stringify
Date: Wed, 25 May 2005 21:57:18 +0100
RT-Send-Cc:
Download (untitled) / with headers
text/plain 1.2k
Show quoted text
----- Original Message ----- From: "Guest via RT" <bug-Devel-Leak-Object@rt.cpan.org> To: <undisclosed-recipients:> Sent: 25 May 2005 17:46 Subject: [cpan #12942] Fix(2) for objects which override stringify
> > > This message about Devel-Leak-Object was sent to you by guest <> via rt.cpan.org > > Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=12942 > > > [guest - Tue May 24 10:12:25 2005]: >
> > The attached (quick'n'dirty) patch fixes the problem you get with > > objects such as those in Test::Unit,
> > That patch was broken - reftype and refaddr were transposed so tracking > was b0rk. > > Attached patch replaces the first one, adds a few extra features. See > also http://www.perlmonks.org/?node_id=150796 for a "what's the REFCNT > of this object?" thread. > > I'll probably do a little more work on this, but I also suspect that > once I get answers to my questions I'll have to abandon the patching at > whatever point I reach.
Thanks for doing this. I've not had a chance to look at either patch yet.
> Hope that's useful,
Sounds like it. I will look to incorporate your latest patch when I next come to make a release. Cheers, Ivor.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.