Skip Menu |
 

This queue is for tickets about the ExtUtils-F77 CPAN distribution.

Report information
The Basics
Id: 129356
Status: open
Priority: 0/
Queue: ExtUtils-F77

People
Owner: Nobody in particular
Requestors: kmx [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: ExtUtils::F77 1.23 broke PDL build on MS Windows
The trouble is in library order where -lquadmath must come after -lgfortran (the order was for some reason changed in 1.23)

Touble is IMO here:

- return( qq{"-L$dir" -L/usr/lib -lgfortran -lquadmath -lm} );
+ my $dir = gfortran_find_libdir($gfortran, 'gfortran');
+ gfortran_make_linkline($dir, "gfortran", "/usr/local/lib", "", '-lquadmath');

In gfortran_make_linkline()

sub gfortran_make_linkline {
  my ($dir, $lib, $defaultdir, $defaultlib, $append) = @_;
  $dir ||= $defaultdir;
  $lib ||= $defaultlib;
  $append ||= '';
  return( qq{"-L$dir" $append -L/usr/lib -l$lib -lm} );
}

you should probably better return

  return( qq{"-L$dir" -L/usr/lib -l$lib $append -lm} );
 
Download (untitled) / with headers
text/plain 767b
+1 在2019-四月-28 14:02:01 星期日时,KMX写到: Show quoted text
> The trouble is in library order where -lquadmath must come after > -lgfortran > (the order was for some reason changed in 1.23) > > Touble is IMO here: > > - return( qq{"-L$dir" -L/usr/lib -lgfortran -lquadmath -lm} ); > + my $dir = gfortran_find_libdir($gfortran, 'gfortran'); > + gfortran_make_linkline($dir, "gfortran", "/usr/local/lib", "", '- > lquadmath'); > In gfortran_make_linkline() > > sub gfortran_make_linkline { my ($dir, $lib, $defaultdir, $defaultlib, > $append) > = @_; $dir ||= $defaultdir; $lib ||= $defaultlib; $append ||= ''; > return( > qq{"-L$dir" $append -L/usr/lib -l$lib -lm} );} > you should probably better return > > return( qq{"-L$dir" -L/usr/lib -l$lib $append -lm} );
Download (untitled) / with headers
text/plain 271b
Thanks, I hadn't seen this as I'm not a co-maint of this distro. I've applied kmx's excellent patch to master. CHM and/or KGB, could you release the latest master? Also, if you add me as co-maint I'd be able to do so, and also able to fix all the issues I can see here.
Subject: Re: [rt.cpan.org #129356] ExtUtils::F77 1.23 broke PDL build on MS Windows
Date: Sun, 21 Jul 2019 14:56:37 +1000
To: bug-ExtUtils-F77 [...] rt.cpan.org
From: Karl Glazebrook <karlglazebrook [...] mac.com>
Download (untitled) / with headers
text/plain 562b
I have released this as v1.24 to CPAN I am happy to add an extra co-maintainer, Ed? best Karl Show quoted text
> On 16 Jul 2019, at 12:44 am, Ed J via RT <bug-ExtUtils-F77@rt.cpan.org> wrote: > > Queue: ExtUtils-F77 > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=129356 > > > Thanks, I hadn't seen this as I'm not a co-maint of this distro. > > I've applied kmx's excellent patch to master. > > CHM and/or KGB, could you release the latest master? Also, if you add me as co-maint I'd be able to do so, and also able to fix all the issues I can see here.
Download (untitled) / with headers
text/plain 208b
Karl, great work! It looks like testers are reporting success on Win32 now. I'd love to be a co-maint. I believe that only CHM can add me, as he's currently "first-come" status - could you ask him to add me?
Subject: Re: [rt.cpan.org #129356] ExtUtils::F77 1.23 broke PDL build on MS Windows
Date: Mon, 22 Jul 2019 15:01:20 +1000
To: bug-ExtUtils-F77 [...] rt.cpan.org
From: Karl Glazebrook <karlglazebrook [...] mac.com>
Download (untitled) / with headers
text/plain 436b
Remind me your github I’d? - Karl Show quoted text
> On 21 Jul 2019, at 11:13 pm, Ed J via RT <bug-ExtUtils-F77@rt.cpan.org> wrote: > > Queue: ExtUtils-F77 > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=129356 > > > Karl, great work! It looks like testers are reporting success on Win32 now. > > I'd love to be a co-maint. I believe that only CHM can add me, as he's currently "first-come" status - could you ask him to add me?


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.