Skip Menu |
 

This queue is for tickets about the Imager-File-WEBP CPAN distribution.

Report information
The Basics
Id: 128954
Status: open
Priority: 0/
Queue: Imager-File-WEBP

People
Owner: Nobody in particular
Requestors: ozcoder [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: whitespace fixes
Date: Fri, 29 Mar 2019 12:50:02 +1100
To: bug-Imager-File-WEBP [...] rt.cpan.org
From: Gordon Stanton <ozcoder [...] gmail.com>
Download (untitled) / with headers
text/plain 242b
Some whitespace fixes to make further patches easier and make the code a little bit more readable. You really shouldn't mix tabs and spaces in code. Maybe you should have a perltidyrc file? Also using snprintf just to be a little bit safer.
Download dump-webp.pl.diff
text/x-diff 6.5k

Message body is not shown because sender requested not to inline it.

Download WEBP.xs.diff
text/x-diff 1.7k

Message body is not shown because sender requested not to inline it.

Download TestImage.pm.diff
text/x-diff 508b

Message body is not shown because sender requested not to inline it.

Download WEBP.pm.diff
text/x-diff 2.5k

Message body is not shown because sender requested not to inline it.

Download Makefile.PL.diff
text/x-diff 3.1k

Message body is not shown because sender requested not to inline it.

Download imwebp.c.diff
text/x-diff 4.9k

Message body is not shown because sender requested not to inline it.

CC: ;
Subject: Re: [rt.cpan.org #128954] whitespace fixes
Date: Sat, 30 Mar 2019 13:34:31 +1100
To: "ozcoder [...] gmail.com via RT" <bug-Imager-File-WEBP [...] rt.cpan.org>
From: Tony Cook <tony [...] develop-help.com>
Download (untitled) / with headers
text/plain 1.1k
On Thu, Mar 28, 2019 at 09:50:28PM -0400, ozcoder@gmail.com via RT wrote: Show quoted text
> Thu Mar 28 21:50:28 2019: Request 128954 was acted upon. > Transaction: Ticket created by ozcoder@gmail.com > Queue: Imager-File-WEBP > Subject: whitespace fixes > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: ozcoder@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=128954 > > > > Some whitespace fixes to make further patches easier and make the code > a little bit more readable. > You really shouldn't mix tabs and spaces in code.
Why not? As long as the tabs are at the beginning of line and your editor isn't broken, they do no harm. I've done some whitespace cleanup in c653569df5fef9a25d6584b78b954d9d823e3093. Show quoted text
> Maybe you should have a perltidyrc file? > > Also using snprintf just to be a little bit safer.
snprintf() isn't always available, I've modified that code to use snprintf() if it's available in 4aa76369d94ba4222b583aebcea592040644edff. As an aside, you don't need to supply sizeof(buf)-1 to snprintf() - it will always NUL terminate the resulting buffer. Tony
Subject: Re: [rt.cpan.org #128954] whitespace fixes
Date: Sat, 30 Mar 2019 18:37:27 +1100
To: bug-Imager-File-WEBP [...] rt.cpan.org
From: Gordon Stanton <ozcoder [...] gmail.com>
Download (untitled) / with headers
text/plain 1.5k
Hi Tony, On Sat, Mar 30, 2019 at 1:34 PM tony@develop-help.com via RT <bug-Imager-File-WEBP@rt.cpan.org> wrote: Show quoted text
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=128954 > > > On Thu, Mar 28, 2019 at 09:50:28PM -0400, ozcoder@gmail.com via RT wrote:
> > Thu Mar 28 21:50:28 2019: Request 128954 was acted upon. > > Transaction: Ticket created by ozcoder@gmail.com > > Queue: Imager-File-WEBP > > Subject: whitespace fixes > > Broken in: (no value) > > Severity: (no value) > > Owner: Nobody > > Requestors: ozcoder@gmail.com > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=128954 > > > > > > > Some whitespace fixes to make further patches easier and make the code > > a little bit more readable. > > You really shouldn't mix tabs and spaces in code.
> > Why not? > > As long as the tabs are at the beginning of line and your editor isn't > broken, they do no harm.
There are so many different editors today. I just thought it would be better to stick to spaces, but it's your project, your style (eg. the fallen/linedUp elses) Show quoted text
> > I've done some whitespace cleanup in c653569df5fef9a25d6584b78b954d9d823e3093. >
> > Maybe you should have a perltidyrc file? > > > > Also using snprintf just to be a little bit safer.
> > snprintf() isn't always available, I've modified that code to use > snprintf() if it's available in 4aa76369d94ba4222b583aebcea592040644edff. > > As an aside, you don't need to supply sizeof(buf)-1 to snprintf() - it > will always NUL terminate the resulting buffer.
I forgot that snprintf isn't universal still.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.