Skip Menu |
 

This queue is for tickets about the MP3-Tag CPAN distribution.

Report information
The Basics
Id: 128915
Status: resolved
Priority: 0/
Queue: MP3-Tag

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: t/mp3tag.t: Dies on perl-5.29.9 on FreeBSD-11.2
Download (untitled) / with headers
text/plain 2.1k
As part of preparation for the upcoming release of perl-5.30.0, I attempted to build and test MP3-Tag on FreeBSD-11.2 using 'cpanm' as the installer. I got many warnings when I ran the test suite; see https://rt.cpan.org/Ticket/Display.html?id=128136 and https://rt.cpan.org/Ticket/Display.html?id=128305 for those. In addition, I got the following failure in t/mp3tag.t: ##### [MP3-Tag-1.14] $ thisprove t/mp3tag.t t/mp3tag.t .. 1..139 Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/^\??({ <-- HERE ([^{}]+)}|.)/ at /usr/home/jkeenan/var/tad/testing/perl-5.29.9/.cpanm/work/1553213716.36088/MP3-Tag-1.14/blib/lib/MP3/Tag.pm line 3080. Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/^({ <-- HERE [^{}]+}|\w)/ at /usr/home/jkeenan/var/tad/testing/perl-5.29.9/.cpanm/work/1553213716.36088/MP3-Tag-1.14/blib/lib/MP3/Tag.pm line 3092. ok 1 # MP3::Tag initialized ok 2 # Detecting ID3v1 ... ok 90 # multi-%c and %=E via parse/interpolate Pattern(s) `%t/%c/%c.%e' did not succeed vs `my/dir/audio_07.mp3' at /usr/home/jkeenan/var/tad/testing/perl-5.29.9/.cpanm/work/1553213716.36088/MP3-Tag-1.14/blib/lib/MP3/Tag/ParseData.pm line 198. Dubious, test returned 2 (wstat 512, 0x200) Failed 49/139 subtests Test Summary Report ------------------- t/mp3tag.t (Wstat: 512 Tests: 90 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 139 tests but ran 90. Files=1, Tests=90, 1 wallclock secs ( 0.02 usr 0.05 sys + 0.25 cusr 0.03 csys = 0.35 CPU) Result: FAIL ##### The relevant part of lib/MP3/Tag/ParseData.pm is: ##### 150 sub parse_one { 151 my ($self, $in) = @_; 152 ... 192 for $pattern (@patterns) { 193 last if $res = $self->{parent}->parse_rex_match($pattern, $data); 194 } 195 last if $res; 196 } 197 { local $" = "' `"; 198 die "Pattern(s) `@opatterns' did not succeed vs `@data'" 199 if $flags =~ /m/ and not $res; 200 } ##### Not yet investigated further. Can you investigate? Thank you very much. Jim Keenan
Download (untitled) / with headers
text/plain 2.5k
On Fri Mar 22 09:17:24 2019, JKEENAN wrote: Show quoted text
> As part of preparation for the upcoming release of perl-5.30.0, I > attempted to build and test MP3-Tag on FreeBSD-11.2 using 'cpanm' as > the installer. I got many warnings when I ran the test suite; see > https://rt.cpan.org/Ticket/Display.html?id=128136 and > https://rt.cpan.org/Ticket/Display.html?id=128305 for those. In > addition, I got the following failure in t/mp3tag.t: > > ##### > [MP3-Tag-1.14] $ thisprove t/mp3tag.t > t/mp3tag.t .. > 1..139 > Unescaped left brace in regex is deprecated here (and will be fatal in > Perl 5.32), passed through in regex; marked by <-- HERE in m/^\??({ > <-- HERE ([^{}]+)}|.)/ at /usr/home/jkeenan/var/tad/testing/perl- > 5.29.9/.cpanm/work/1553213716.36088/MP3-Tag-1.14/blib/lib/MP3/Tag.pm > line 3080. > Unescaped left brace in regex is deprecated here (and will be fatal in > Perl 5.32), passed through in regex; marked by <-- HERE in m/^({ <-- > HERE [^{}]+}|\w)/ at /usr/home/jkeenan/var/tad/testing/perl- > 5.29.9/.cpanm/work/1553213716.36088/MP3-Tag-1.14/blib/lib/MP3/Tag.pm > line 3092. > ok 1 # MP3::Tag initialized > ok 2 # Detecting ID3v1 > ... > ok 90 # multi-%c and %=E via parse/interpolate > Pattern(s) `%t/%c/%c.%e' did not succeed vs `my/dir/audio_07.mp3' at > /usr/home/jkeenan/var/tad/testing/perl- > 5.29.9/.cpanm/work/1553213716.36088/MP3-Tag- > 1.14/blib/lib/MP3/Tag/ParseData.pm line 198. > Dubious, test returned 2 (wstat 512, 0x200) > Failed 49/139 subtests > > Test Summary Report > ------------------- > t/mp3tag.t (Wstat: 512 Tests: 90 Failed: 0) > Non-zero exit status: 2 > Parse errors: Bad plan. You planned 139 tests but ran 90. > Files=1, Tests=90, 1 wallclock secs ( 0.02 usr 0.05 sys + 0.25 cusr > 0.03 csys = 0.35 CPU) > Result: FAIL > ##### > > The relevant part of lib/MP3/Tag/ParseData.pm is: > > ##### > 150 sub parse_one { > 151 my ($self, $in) = @_; > 152 > ... > 192 for $pattern (@patterns) { > 193 last if $res = $self->{parent}->parse_rex_match($pattern, > $data); > 194 } > 195 last if $res; > 196 } > 197 { local $" = "' `"; > 198 die "Pattern(s) `@opatterns' did not succeed vs `@data'" > 199 if $flags =~ /m/ and not $res; > 200 } > ##### > > Not yet investigated further. Can you investigate? > > Thank you very much. > Jim Keenan
Strictly speaking, this is a "blead breaks CPAN" incident; see https://rt.perl.org/Ticket/Display.html?id=133948. However, given that this module needs work to avert deprecation warnings, it might be good to coordinate with P5P on a solution. Thank you very much. Jim Keenan
CC: ;
Subject: Re: [rt.cpan.org #128915] t/mp3tag.t: Dies on perl-5.29.9 on FreeBSD-11.2
Date: Fri, 22 Mar 2019 18:18:40 -0700
To: James E Keenan via RT <bug-MP3-Tag [...] rt.cpan.org>
From: Ilya Zakharevich <nospam-abuse [...] ilyaz.org>
Download (untitled) / with headers
text/plain 997b
On Fri, Mar 22, 2019 at 01:56:06PM -0400, James E Keenan via RT wrote: Show quoted text
> Queue: MP3-Tag > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=128915 > > > On Fri Mar 22 09:17:24 2019, JKEENAN wrote:
> > As part of preparation for the upcoming release of perl-5.30.0, I > > attempted to build and test MP3-Tag on FreeBSD-11.2 using 'cpanm' as > > the installer. I got many warnings when I ran the test suite; see > > https://rt.cpan.org/Ticket/Display.html?id=128136 and > > https://rt.cpan.org/Ticket/Display.html?id=128305 for those. In > > addition, I got the following failure in t/mp3tag.t:
Show quoted text
> Strictly speaking, this is a "blead breaks CPAN" incident; see https://rt.perl.org/Ticket/Display.html?id=133948. > > However, given that this module needs work to avert deprecation warnings, it might be good to coordinate with P5P on a solution.
Thanks, I fixed the warnings in v1.15 (indexed on CPAN a few minutes ago), so you are now in a position to re-check. Yours, Ilya
Download (untitled) / with headers
text/plain 2.4k
On Fri Mar 22 21:20:54 2019, nospam-abuse@ilyaz.org wrote: Show quoted text
> On Fri, Mar 22, 2019 at 01:56:06PM -0400, James E Keenan via RT wrote:
> > Queue: MP3-Tag > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=128915 > > > > > On Fri Mar 22 09:17:24 2019, JKEENAN wrote:
> > > As part of preparation for the upcoming release of perl-5.30.0, I > > > attempted to build and test MP3-Tag on FreeBSD-11.2 using 'cpanm' > > > as > > > the installer. I got many warnings when I ran the test suite; see > > > https://rt.cpan.org/Ticket/Display.html?id=128136 and > > > https://rt.cpan.org/Ticket/Display.html?id=128305 for those. In > > > addition, I got the following failure in t/mp3tag.t:
> > … >
> > Strictly speaking, this is a "blead breaks CPAN" incident; see > > https://rt.perl.org/Ticket/Display.html?id=133948. > > > > However, given that this module needs work to avert deprecation > > warnings, it might be good to coordinate with P5P on a solution.
> > Thanks, I fixed the warnings in v1.15 (indexed on CPAN a few minutes > ago), so you are now in a position to re-check. > > Yours, > Ilya
You may have a problem with your CPAN upload. Here's what I got just now when trying to install MP3::Tag on Linux at blead HEAD with cpanm: ##### $ ./bin/cpanm MP3::Tag --> Working on MP3::Tag Fetching http://www.cpan.org/authors/id/I/IL/ILYAZ/modules/MP3-Tag-1.15.zip ... OK End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive. unzip: cannot find zipfile directory in one of MP3-Tag-1.15.zip or MP3-Tag-1.15.zip.zip, and cannot find MP3-Tag-1.15.zip.ZIP, period. [MP3-Tag-1.15.zip] End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive. unzip: cannot find zipfile directory in one of MP3-Tag-1.15.zip or MP3-Tag-1.15.zip.zip, and cannot find MP3-Tag-1.15.zip.ZIP, period. ! Bad archive: [] MP3-Tag-1.15.zip ! Failed to unpack MP3-Tag-1.15.zip: no directory ! Failed to fetch distribution MP3-Tag-1.15 ##### I can see this URL: ftp://ftp.funet.fi/pub/CPAN/authors/id/I/IL/ILYAZ/modules/MP3-Tag-1.15.zip ... but generally I expect a '.tar.gz' tarball rather than a .zip file. Thank you very much. Jim Keenan
CC: ;
Subject: Re: [rt.cpan.org #128915] t/mp3tag.t: Dies on perl-5.29.9 on FreeBSD-11.2
Date: Sat, 23 Mar 2019 14:38:07 -0700
To: James E Keenan via RT <bug-MP3-Tag [...] rt.cpan.org>
From: Ilya Zakharevich <nospam-abuse [...] ilyaz.org>
Download (untitled) / with headers
text/plain 830b
On Sat, Mar 23, 2019 at 09:15:04AM -0400, James E Keenan via RT wrote: Show quoted text
> > Thanks, I fixed the warnings in v1.15 (indexed on CPAN a few minutes > > ago), so you are now in a position to re-check.
Show quoted text
> You may have a problem with your CPAN upload.
Nope. As I said, it is indexed successfully on PAUSE. Show quoted text
> Here's what I got just now when trying to install MP3::Tag on Linux at blead HEAD with cpanm: > > ##### > $ ./bin/cpanm MP3::Tag > --> Working on MP3::Tag > Fetching http://www.cpan.org/authors/id/I/IL/ILYAZ/modules/MP3-Tag-1.15.zip ... OK
This “OK” is probably a lie. I did (using another address from the list in your log) wget ftp://ftp.funet.fi/pub/CPAN/authors/id/I/IL/ILYAZ/modules/MP3-Tag-1.15.zip unzip -t MP3-Tag-1.15.zip and get No errors detected in compressed data of MP3-Tag-1.15.zip. Yours, Ilya
On Sat Mar 23 17:40:18 2019, nospam-abuse@ilyaz.org wrote: Show quoted text
> On Sat, Mar 23, 2019 at 09:15:04AM -0400, James E Keenan via RT wrote:
> > > Thanks, I fixed the warnings in v1.15 (indexed on CPAN a few > > > minutes > > > ago), so you are now in a position to re-check.
>
> > You may have a problem with your CPAN upload.
> > Nope. As I said, it is indexed successfully on PAUSE. >
> > Here's what I got just now when trying to install MP3::Tag on Linux > > at blead HEAD with cpanm: > > > > ##### > > $ ./bin/cpanm MP3::Tag > > --> Working on MP3::Tag > > Fetching http://www.cpan.org/authors/id/I/IL/ILYAZ/modules/MP3-Tag- > > 1.15.zip ... OK
> > This “OK” is probably a lie. > > I did (using another address from the list in your log) > wget ftp://ftp.funet.fi/pub/CPAN/authors/id/I/IL/ILYAZ/modules/MP3- > Tag-1.15.zip > unzip -t MP3-Tag-1.15.zip > and get > No errors detected in compressed data of MP3-Tag-1.15.zip. > > Yours, > Ilya
Okay. On subsequent attempts the .zip file downloaded as expected and I was able to install. Thank you very much. Jim Keenan


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.