Skip Menu |
 

This queue is for tickets about the ExtUtils-ModuleMaker-Siffra CPAN distribution.

Report information
The Basics
Id: 128847
Status: open
Priority: 0/
Queue: ExtUtils-ModuleMaker-Siffra

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.03
  • 0.04
Fixed in: (no value)



Subject: Perl::Critic tests may fail (0.03)
Download (untitled) / with headers
text/plain 1.3k
On some of my smokers: ... # Failed test 'Test::Perl::Critic for "blib/lib/ExtUtils/ModuleMaker/Siffra.pm"' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line 121. # # Use of "require" is not allowed at line 13, column 5. Use Require() method of MainObject instead. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 21, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 22, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 40, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 42, column 8. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 93, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 95, column 10. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 95, column 17. (no explanation). (Severity: 5) ... (etc) ... t/perlcritic.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Probably failure or non-failure depends on the set of perlcritic policies installed on a system.
Download (untitled) / with headers
text/plain 874b
On 2019-03-16 00:29:20, SREZIC wrote: Show quoted text
> On some of my smokers: > > ... > # Failed test 'Test::Perl::Critic for > "blib/lib/ExtUtils/ModuleMaker/Siffra.pm"' > # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line > 121.
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
Download (untitled) / with headers
text/plain 1.5k
On 2019-03-16 03:29:20, SREZIC wrote: Show quoted text
> On some of my smokers: > > ... > # Failed test 'Test::Perl::Critic for > "blib/lib/ExtUtils/ModuleMaker/Siffra.pm"' > # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line > 121. > # > # Use of "require" is not allowed at line 13, column 5. Use > Require() method of MainObject instead. (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 21, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 22, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 40, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 42, column 8. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 93, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 95, column 10. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 95, column 17. (no explanation). (Severity: 5) > ... (etc) ... > t/perlcritic.t .... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests > > > Probably failure or non-failure depends on the set of perlcritic > policies installed on a system.
Also it fails if Test::Perl::Critic is not installed at all (0.04).


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.