Skip Menu |
 

This queue is for tickets about the Template-Plugin-JSON CPAN distribution.

Report information
The Basics
Id: 128679
Status: resolved
Priority: 0/
Queue: Template-Plugin-JSON

People
Owner: ether [...] cpan.org
Requestors: me [...] eboxr.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.08



Subject: Failure with old version of Test-Simple which does not provides ok...
Download (untitled) / with headers
text/plain 1.4k
On that box I was using Test::Simple 1.001003 with Perl 5.14 which provides Test::More (without ok.pm) and while trying to build Template::Plugin::JSON I could notice one error as 'ok.pm' is not provided by old module. After checking Test::Simple repo it seems that `ok.pm` was introduced in Version 1.001010 https://github.com/Test-More/test-more/commit/ff91352be4b59b28dbc792276a5785ed1e92f2a1#diff-ee1ceb573f530c93e1869b3f8917b1de ```perl #!/usr/bin/perl use strict; use warnings; use Test::More tests => 9; use Template; use JSON; use ok 'Template::Plugin::JSON'; ``` which would result in the failure ``` Can't locate ok.pm in @INC (@INC contains: /home/rpmbuild/rpm-build/BUILD/Template-Plugin-JSON-0.07/blib/lib /home/rpmbuild/rpm-build/BUILD/Template-Plugin-JSON-0.07/blib/arch /usr/local/cpanel /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/cpanel_lib/x86_64-linux-64int /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/cpanel_lib /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/5.14.4/x86_64-linux-64int /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/5.14.4 /opt/cpanel/perl5/514/site_lib/x86_64-linux-64int /opt/cpanel/perl5/514/site_lib .) at t/live.t line 11. BEGIN failed--compilation aborted at t/live.t line 11. ``` The Makefile.PL dependencies section for testing should be bump. - either we ask a minimal version for Test::Simple or Test::More - 1.001010 minimum - either we also list `ok` as a required dependency for testing
Download (untitled) / with headers
text/plain 1.7k
note that an alternate solution which would avoid to update Test::Simple is to do not use 'use ok' in the unit test... the test will fail if the use statement fails... On Fri Mar 01 11:43:48 2019, atoomic wrote: Show quoted text
> On that box I was using Test::Simple 1.001003 with Perl 5.14 which > provides Test::More (without ok.pm) > and while trying to build Template::Plugin::JSON I could notice one > error > as 'ok.pm' is not provided by old module. > > After checking Test::Simple repo it seems that `ok.pm` was introduced > in Version 1.001010 > https://github.com/Test-More/test- > more/commit/ff91352be4b59b28dbc792276a5785ed1e92f2a1#diff- > ee1ceb573f530c93e1869b3f8917b1de > > ```perl > #!/usr/bin/perl > > use strict; > use warnings; > > use Test::More tests => 9; > > use Template; > use JSON; > > use ok 'Template::Plugin::JSON'; > ``` > > which would result in the failure > ``` > Can't locate ok.pm in @INC (@INC contains: /home/rpmbuild/rpm- > build/BUILD/Template-Plugin-JSON-0.07/blib/lib /home/rpmbuild/rpm- > build/BUILD/Template-Plugin-JSON-0.07/blib/arch /usr/local/cpanel > /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/cpanel_lib/x86_64- > linux-64int /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/cpanel_lib > /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/5.14.4/x86_64-linux- > 64int /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/5.14.4 > /opt/cpanel/perl5/514/site_lib/x86_64-linux-64int > /opt/cpanel/perl5/514/site_lib .) at t/live.t line 11. > BEGIN failed--compilation aborted at t/live.t line 11. > ``` > > The Makefile.PL dependencies section for testing should be bump. > - either we ask a minimal version for Test::Simple or Test::More - > 1.001010 minimum > - either we also list `ok` as a required dependency for testing
submitted as https://github.com/neilb/Template-Plugin-JSON/pull/2 PS: would not it makes more sense to use GitHub bug tracker instead of RT, this would have the advantage of having the source code, issues and PR in the same location... On Fri Mar 01 11:52:16 2019, atoomic wrote: Show quoted text
> note that an alternate solution which would avoid to update > Test::Simple is to do not use 'use ok' in the unit test... > the test will fail if the use statement fails... > > On Fri Mar 01 11:43:48 2019, atoomic wrote:
> > On that box I was using Test::Simple 1.001003 with Perl 5.14 which > > provides Test::More (without ok.pm) > > and while trying to build Template::Plugin::JSON I could notice one > > error > > as 'ok.pm' is not provided by old module. > > > > After checking Test::Simple repo it seems that `ok.pm` was introduced > > in Version 1.001010 > > https://github.com/Test-More/test- > > more/commit/ff91352be4b59b28dbc792276a5785ed1e92f2a1#diff- > > ee1ceb573f530c93e1869b3f8917b1de > > > > ```perl > > #!/usr/bin/perl > > > > use strict; > > use warnings; > > > > use Test::More tests => 9; > > > > use Template; > > use JSON; > > > > use ok 'Template::Plugin::JSON'; > > ``` > > > > which would result in the failure > > ``` > > Can't locate ok.pm in @INC (@INC contains: /home/rpmbuild/rpm- > > build/BUILD/Template-Plugin-JSON-0.07/blib/lib /home/rpmbuild/rpm- > > build/BUILD/Template-Plugin-JSON-0.07/blib/arch /usr/local/cpanel > > /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/cpanel_lib/x86_64- > > linux-64int > > /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/cpanel_lib > > /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/5.14.4/x86_64-linux- > > 64int /usr/local/cpanel/3rdparty/perl/514/lib64/perl5/5.14.4 > > /opt/cpanel/perl5/514/site_lib/x86_64-linux-64int > > /opt/cpanel/perl5/514/site_lib .) at t/live.t line 11. > > BEGIN failed--compilation aborted at t/live.t line 11. > > ``` > > > > The Makefile.PL dependencies section for testing should be bump. > > - either we ask a minimal version for Test::Simple or Test::More - > > 1.001010 minimum > > - either we also list `ok` as a required dependency for testing
Thanks, this has been fixed in release 0.08.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.