Skip Menu |
 

This queue is for tickets about the Test-PerlTidy CPAN distribution.

Report information
The Basics
Id: 127688
Status: resolved
Priority: 0/
Queue: Test-PerlTidy

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc: perltidy [...] users.sourceforge.net
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 20130104
  • 20190305
Fixed in: (no value)



CC: perltidy [...] users.sourceforge.net
Subject: Fails with Perl::Tidy 20181117 (alignment changes)
Download (untitled) / with headers
text/plain 2.7k
The test suite started to fail. Test log starts with: ... # The file 'lib/Test/PerlTidy.pm' is not tidy # +----+---------------------------------------------------------------+-------------------------------------------------------------------+ # | 80| # Do not worry about trailing newlines. | # Do not worry about trailing newlines. | # | 81| # | # | # | 82| $code_to_tidy =~ s/[\r\n]+$//; | $code_to_tidy =~ s/[\r\n]+$//; | # * 83| $tidied_code =~ s/[\r\n]+$//; | $tidied_code =~ s/[\r\n]+$//; * # | 84| if ( $code_to_tidy eq $tidied_code ) { | if ( $code_to_tidy eq $tidied_code ) { | # | 85| return 1; | return 1; | # | 86| } | } | # +----+---------------------------------------------------------------+-------------------------------------------------------------------+ # | 131| $finder->{options}->{untaint} = 1; | $finder->{options}->{untaint} = 1; | # | 132| my @files = $finder->in($path); | my @files = $finder->in($path); | # | 133| | | # * 134| my %keep = map { File::Spec->canonpath($_) => 1 } @files; | my %keep = map { File::Spec->canonpath($_) => 1 } @files; * # | 135| my @excluded = (); | my @excluded = (); | # | 136| | | # | 137| foreach my $file ( keys %keep ) { | foreach my $file ( keys %keep ) { | # +----+---------------------------------------------------------------+-------------------------------------------------------------------+ # Failed test ''lib/Test/PerlTidy.pm'' # at t/exclude_perltidy.t line 11. # Looks like you failed 1 test of 11. t/exclude_perltidy.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests ... In https://metacpan.org/source/SHANCOCK/Perl-Tidy-20181117/CHANGES.md#L55 I see changes regarding the alignment.
Download (untitled) / with headers
text/plain 2.4k
On Sat Nov 17 09:59:06 2018, SREZIC wrote: Show quoted text
> The test suite started to fail. Test log starts with: >
should be fine in 0305.001. Show quoted text
> ... > # The file 'lib/Test/PerlTidy.pm' is not tidy > # +---- > +--------------------------------------------------------------- > +-------------------------------------------------------------------+ > # | 80| # Do not worry about trailing newlines. > | # Do not worry about trailing newlines. | > # | 81| # > | # | > # | 82| $code_to_tidy =~ s/[\r\n]+$//; > | $code_to_tidy =~ s/[\r\n]+$//; | > # * 83| $tidied_code =~ s/[\r\n]+$//; > | $tidied_code =~ s/[\r\n]+$//; * > # | 84| if ( $code_to_tidy eq $tidied_code ) { > | if ( $code_to_tidy eq $tidied_code ) { | > # | 85| return 1; > | return 1; | > # | 86| } > | } | > # +---- > +--------------------------------------------------------------- > +-------------------------------------------------------------------+ > # | 131| $finder->{options}->{untaint} = 1; > | $finder->{options}->{untaint} = 1; | > # | 132| my @files = $finder->in($path); > | my @files = $finder->in($path); | > # | 133| > | | > # * 134| my %keep = map { File::Spec->canonpath($_) => 1 } @files; > | my %keep = map { File::Spec->canonpath($_) => 1 } @files; * > # | 135| my @excluded = (); > | my @excluded = (); | > # | 136| > | | > # | 137| foreach my $file ( keys %keep ) { > | foreach my $file ( keys %keep ) { | > # +---- > +--------------------------------------------------------------- > +-------------------------------------------------------------------+ > > # Failed test ''lib/Test/PerlTidy.pm'' > # at t/exclude_perltidy.t line 11. > # Looks like you failed 1 test of 11. > t/exclude_perltidy.t .. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/11 subtests > ... > > In https://metacpan.org/source/SHANCOCK/Perl-Tidy- > 20181117/CHANGES.md#L55 I see changes regarding the alignment.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.