Skip Menu |
 

This queue is for tickets about the App-GitHub-Repository CPAN distribution.

Report information
The Basics
Id: 127595
Status: open
Priority: 0/
Queue: App-GitHub-Repository

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.0.3
Fixed in: (no value)



Subject: Perl::Critic tests may fail
Download (untitled) / with headers
text/plain 943b
Probably depends on which perlcritic policies are installed: ... # Failed test 'Test::Perl::Critic for "blib/lib/App/GitHub/Repository.pm"' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line 121. # # Variable, subroutine, and package names have to be in CamelCase at line 24, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 25, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 26, column 6. (no explanation). (Severity: 5) ... (etc) ... # Variable, subroutine, and package names have to be in CamelCase at line 99, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 100, column 10. (no explanation). (Severity: 5) t/perlcritic.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
Download (untitled) / with headers
text/plain 739b
On 2018-11-07 11:00:39, SREZIC wrote: Show quoted text
> Probably depends on which perlcritic policies are installed:
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.