Skip Menu |
 

This queue is for tickets about the Test-PerlTidy CPAN distribution.

Report information
The Basics
Id: 127452
Status: resolved
Priority: 0/
Queue: Test-PerlTidy

People
Owner: Nobody in particular
Requestors: PLICEASE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Does not install on Windows
As you can see by the CPAN testers results, this module doesn't test correctly on Windows: # Looks like your test exited with 255 before it could output anything. t/exclude_files.t ..... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests insecure cwd in find(depth) at C:/Strawberry280RC1/perl/lib/File/Find.pm line 278. t/exclude_perltidy.t .. Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run t/is_file_tidy.t ...... ok insecure cwd in find(depth) at C:/Strawberry280RC1/perl/lib/File/Find.pm line 278. # Looks like your test exited with 255 before it could output anything. t/list_files.t ........ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests insecure cwd in find(depth) at C:/Strawberry280RC1/perl/lib/File/Find.pm line 278. t/perltidy.t .......... Dubious, test returned 255 (wstat 65280, 0xff00) I had a similar problem with Test-Version, and I solved it by providing FIle::Find with an untaint pattern which understands the unique nature of Windows unusual file system: https://metacpan.org/source/PLICEASE/Test-Version-2.09/lib/Test/Version.pm#L91
Download (untitled) / with headers
text/plain 190b
I propose this PR to resolve the issue: https://github.com/larryl/Test-PerlTidy/pull/4 It is similar to the approach taken by Test::Version, but adheres to the critic policy for this dist.
Download (untitled) / with headers
text/plain 266b
On Thu Oct 25 15:32:34 2018, PLICEASE wrote: Show quoted text
> I propose this PR to resolve the issue: > > https://github.com/larryl/Test-PerlTidy/pull/4 > > It is similar to the approach taken by Test::Version, but adheres to > the critic policy for this dist.
should be ok now.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.