Skip Menu |
 

This queue is for tickets about the Kasago CPAN distribution.

Report information
The Basics
Id: 127396
Status: open
Priority: 0/
Queue: Kasago

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.29
Fixed in: (no value)



Subject: t/pod_coverage.t fails
Download (untitled) / with headers
text/plain 558b
The pod coverage test fails: ... # Failed test 'Pod coverage on Kasago' # at /opt/perl-5.26.2/lib/site_perl/5.26.2/Test/Pod/Coverage.pm line 133. # Kasago: requiring 'Kasago' failed # Looks like you failed 1 test of 3. t/pod_coverage.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests DBI connect('dbname=kasago_test','',...) failed: could not connect to server: No such file or directory Is the server running locally and accepting connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"? at t/simple.t line 10. ...
Download (untitled) / with headers
text/plain 1.2k
On 2018-10-17 12:51:52, SREZIC wrote: Show quoted text
> The pod coverage test fails: > > ... > # Failed test 'Pod coverage on Kasago' > # at /opt/perl-5.26.2/lib/site_perl/5.26.2/Test/Pod/Coverage.pm line > 133. > # Kasago: requiring 'Kasago' failed > # Looks like you failed 1 test of 3. > t/pod_coverage.t .. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/3 subtests > DBI connect('dbname=kasago_test','',...) failed: could not connect to > server: No such file or directory > Is the server running locally and accepting > connections on Unix domain socket > "/var/run/postgresql/.s.PGSQL.5432"? at t/simple.t line 10. > ...
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
Download (untitled) / with headers
text/plain 883b
On 2018-10-17 15:51:52, SREZIC wrote: Show quoted text
> The pod coverage test fails: > > ... > # Failed test 'Pod coverage on Kasago' > # at /opt/perl-5.26.2/lib/site_perl/5.26.2/Test/Pod/Coverage.pm line > 133. > # Kasago: requiring 'Kasago' failed > # Looks like you failed 1 test of 3. > t/pod_coverage.t .. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/3 subtests > DBI connect('dbname=kasago_test','',...) failed: could not connect to > server: No such file or directory > Is the server running locally and accepting > connections on Unix domain socket > "/var/run/postgresql/.s.PGSQL.5432"? at t/simple.t line 10. > ...
However, this isn't a problem of Pod coverage, but the skip really has to be skipped because the module cannot be required because of the missing DB. (But I think it's not OK if a module already creates a DB connection if it's just used)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.