Skip Menu |
 

This queue is for tickets about the Zodiac-Chinese CPAN distribution.

Report information
The Basics
Id: 127317
Status: new
Priority: 0/
Queue: Zodiac-Chinese

People
Owner: Nobody in particular
Requestors: TMTVL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: Remove unnecessary subtraction from sign calculation.
Download (untitled) / with headers
text/plain 437b
Hello, I was looking at the source of the module and noticed you were subtracting 1924 from the year value in order to make the modulo match up to the sign. I was just wondering if you would consider simply rearranging the signs so you don't need the subtraction? If you want to preserve the order of the signs you could just subtract 4 from the year to match it up. If you want I can provide a patch or a pull request. Cheers, -Tim


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.