Skip Menu |
 

This queue is for tickets about the Module-Version CPAN distribution.

Report information
The Basics
Id: 127128
Status: open
Priority: 0/
Queue: Module-Version

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.13
Fixed in: (no value)

Attachments


Subject: [PATCH] Random t/app.t failures
Download (untitled) / with headers
text/plain 111b
Looks like a simple mistake in the test suite. I'd suggest to remove a line with no plausible meaning. -Martin
Subject: Module-Version-0.13-MHASCH-01.patch
diff -rup Module-Version-0.13.orig/t/app.t Module-Version-0.13/t/app.t --- Module-Version-0.13.orig/t/app.t 2018-08-26 22:55:37.000000000 +0200 +++ Module-Version-0.13/t/app.t 2018-09-18 16:57:34.914127640 +0200 @@ -43,7 +43,6 @@ my $run = sub { $app->run() }; # check run() without input $app->{'modules'} = ['Test::More']; my $ver = $Test::More::VERSION; - $ver = '1.3021350'; $ver =~ s/0+$//; stdout_is( $run, "$ver\n", 'run() ok - regular' ); }
Download (untitled) / with headers
text/plain 309b
It turns out that dropping the line that assigns some constant to $ver is not always sufficient. With Test::More v1.302140, say, the output actually has a trailing zero. A more robust approach might be to normalize both strings before comparing them. Anybody with deeper insights, please comment. -Martin
Download (untitled) / with headers
text/plain 549b
On 2018-09-18 11:39:35, MHASCH wrote: Show quoted text
> It turns out that dropping the line that assigns some > constant to $ver is not always sufficient. > With Test::More v1.302140, say, the output actually has > a trailing zero. > > A more robust approach might be to normalize both strings > before comparing them. Anybody with deeper insights, > please comment. >
Here's an alternative patch which hopefully does not care if there's a trailing zero or not: http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/Module-Version-0.13-RT127128.patch


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.