This queue is for tickets about the Test-Smoke CPAN distribution.

Report information
The Basics
Id:
126271
Status:
new
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
jkeenan [...] pobox.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Subject: smokestatus.pl does not correctly report branch being smoked
Date: Tue, 14 Aug 2018 10:19:14 -0400
To: bug-Test-Smoke@rt.cpan.org
From: James E Keenan <jkeenan@pobox.com>
As I write I am conducting a smoke test of the following branch in the Perl 5 core repository: smoke-me/jkeenan/133382-Test-Simple-trial I designated this branch for testing by listing it as the top entry in the 'smokecurrent.gitbranch' file: ##### smoke-me/jkeenan/133382-Test-Simple-trial blead smoke-me/khw-locale blead ... ##### Notwithstanding the fact that I've been using Test-Smoke for two years, I just now discovered the program 'smokestatus.pl'. Running it, I get: ##### $ ./smokestatus.pl -c smokecurrent_config ./smokestatus.pl-0.014 Test::Smoke-1.72 Test::Smoke::Reporter-0.053 Checking status for configuration 'smokecurrent_config' (blead) Change number 22449cbbe7072a962ee1b533b65d93cec20f7cca started on Tue Aug 14 13:50:56 2018. 0 out of 1 configurations finished. 0 failures in the running configuration. 1 configuration to finish. ##### This output is misleading. I'm not smoking 'blead'; I'm smoking 'smoke-me/jkeenan/133382-Test-Simple-trial'. Examining the code I see that 'smokestatus.pl' relies solely on 'smokecurrent_config' for its information as to which branch is being smoked. In 'smokecurrent_config' I have: ##### $ grep -n blead smokecurrent_config 10: gitdfbranch => "blead", 24: perl_version => "blead", ##### And it's (the misleadingly named) 'perl_version' value that is used in 'smokestatus.pl': ##### my $pver = $opt{perl_version} ? " ($opt{perl_version})" : ""; print "Checking status for configuration '$opt{config}'$pver\n"; ##### But when I'm actually running a smoke test the values set in 'smokecurrent_config' may be overridden by values set in 'smokecurrent.gitbranch' and other configuration files. Indeed, in my case some of them usually are overridden. The result is that the branch actually being smoked in the 'perl-current' directory is not correctly represented in the output of 'smokestatus.pl'. A quick way to *partially* improve this would be to simply not attempt to provide information on the branch being tested, i.e., eliminate " (blead)" from the output of 'smokestatus.pl'. No information would be better than incorrect information. Thank you very much. Jim Keenan


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.