Skip Menu |
 

This queue is for tickets about the Net-IMAP-Simple CPAN distribution.

Report information
The Basics
Id: 125883
Status: open
Priority: 0/
Queue: Net-IMAP-Simple

People
Owner: Nobody in particular
Requestors: roman [...] parparov.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: _cmd_ok bug - not handling a case happening with Outlook365 IMAP
Date: Wed, 18 Jul 2018 12:54:48 -0700
To: bug-Net-IMAP-Simple [...] rt.cpan.org
From: Roman Parparov <roman [...] parparov.com>
Download (untitled) / with headers
text/plain 1.2k
Hi guys, Great work, but in the version 1.2209 (and as I checked, in 1.2212) there is a problem handling out in _cmd_ok (line 1182 in 1.2209): sub _cmd_ok {     my ( $self, $res ) = @_;     my $id = $self->_count;     $self->_debug( caller, __LINE__, '_cmd_ok', $res ) if $self->{debug};     if ( $res =~ /^$id\s+OK/i ) {         return 1;     } elsif ( $res =~ /^$id\s+(?:NO|BAD)(?:\s+(.+))?/i ) {         $self->_seterrstr( $1 || 'unknown error' );         return 0;     } elsif ( $res =~ m/^\*\s+/ ) {     }else {         $self->_seterrstr("warning unknown return string (id=$id): $res");     }     return; } Unfortunately, Outlook365 IMAP implementation has been noticed to arbitrarily close the connection sending: [...re/perl5/Net/IMAP/Simple.pm line 1126 in sub _process_cmd] * BYE Connection is closed. 13\r\n [...re/perl5/Net/IMAP/Simple.pm line 1277 in sub _cmd_ok] * BYE Connection is closed. 13\r\n which are thus unparsed and not taken care of. After that you can continue to pump commands into IMAP pipeline and after about a fifty such commands the script will die without a reason. I don't know what the patch should be, but at least some _seterrstr should be called. Thanks, Roman.
Download (untitled) / with headers
text/plain 1.7k
Hrm. I'm not sure what can be done about that. I'm thinking about it. Since you've had time to think about it... have you had any ideas? BTW, sorry for the late reply. I didn't notice this in a timely fashion. On Wed Jul 18 15:55:03 2018, ROMM wrote: Show quoted text
> Hi guys, > > Great work, but in the version 1.2209 (and as I checked, in 1.2212) > there is a problem handling out in _cmd_ok (line 1182 in 1.2209): > > sub _cmd_ok { >     my ( $self, $res ) = @_; >     my $id = $self->_count; > >     $self->_debug( caller, __LINE__, '_cmd_ok', $res ) if $self->{debug}; > >     if ( $res =~ /^$id\s+OK/i ) { >         return 1; > >     } elsif ( $res =~ /^$id\s+(?:NO|BAD)(?:\s+(.+))?/i ) { >         $self->_seterrstr( $1 || 'unknown error' ); >         return 0; > >     } elsif ( $res =~ m/^\*\s+/ ) { > >     }else { >         $self->_seterrstr("warning unknown return string (id=$id): $res"); >     } > >     return; > } > > Unfortunately, Outlook365 IMAP implementation has been noticed to > arbitrarily close the connection sending: > [...re/perl5/Net/IMAP/Simple.pm line 1126 in sub _process_cmd] * BYE > Connection is closed. 13\r\n > [...re/perl5/Net/IMAP/Simple.pm line 1277 in sub _cmd_ok] * BYE > Connection is closed. 13\r\n > which are thus unparsed and not taken care of. After that you can > continue to pump commands into IMAP pipeline and after about a fifty > such commands the script will die without a reason. > > I don't know what the patch should be, but at least some _seterrstr > should be called. > > Thanks, > Roman.
-- If riding in an airplane is flying, then riding in a boat is swimming. 116 jumps, 48.6 minutes of freefall, 92.9 freefall miles.
Subject: Re: [rt.cpan.org #125883] _cmd_ok bug - not handling a case happening with Outlook365 IMAP
Date: Sat, 11 Aug 2018 15:51:24 -0700
To: bug-Net-IMAP-Simple [...] rt.cpan.org
From: Roman Parparov <roman [...] parparov.com>
Download (untitled) / with headers
text/plain 4.3k
Hi Paul, So actually I think the * BYE or * qr/.*backoff.*/i or something may need to be tested for. The problem is that at least in my case (I am working with MAPI, Office365 IMAP server) the server uses this response either to inform that the sock has been shut down, or that the client is throttled and needs to back off. What currently happens is that Net::IMAP::Simple is unaware that the sock it wants to print to has been shut down, tries to print something into it, and perl quietly(!) SIGPIPES and exits, not dies, but just exits with SIGPIPE errno. Right now I built a wrapper of sorts (sorry, I can't share more at this point): readline_callback => sub {       push(@{$self->{imap_responses}}, $_[0])       if $_[0] =~ /^(\d+|\*) /i; } sub errstr ($) {         my $self = shift;         my $errstr = $Net::IMAP::Simple::errstr                 || $self->{imap_responses}[-1]                 || 'Unknown error';         $errstr; } sub handle_failure ($$) {         my $self = shift;         my $cmd  = shift;         my $args = shift;         $self->log_it("$cmd $args failed: " . $self->errstr);         if ($self->errstr =~ /backoff.* (\d+) millise/i) {                 my $tosleep = ($1+100000)*1000;                 $self->log_it("Throttling encountered, backing off");                 my $sock = $self->{imap}->_sock();                 $self->disconnect();                 $sock = undef;                 usleep $tosleep;         }         else {                 sleep $self->{config}{command_failure_sleep};         } } sub disconnect ($) {         my $self = shift;         if ($self->{imap} && $self->{imap}->_sock && $self->{imap}->_sock->connected) { $self->{imap}->_sock->shutdown(2);                 sleep 1;         } } sub get_status ($) {         my $self = shift;         $self->{imap_responses}                 && @{$self->{imap_responses}}                 && $self->{imap_responses}[-1] =~ /^$self->{imap}{count} OK / } And when I execute a command, I test:                 if (! $sock || ! $sock->connected) {                         $imap = $self->reconnect($type, $retries+1);                         unshift(@commands, 'login') unless $command eq 'login';                 } Thanks for your time and effort, R. On 8/10/18 7:03 AM, Paul Miller via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=125883 > > > Hrm. I'm not sure what can be done about that. I'm thinking about it. Since you've had time to think about it... have you had any ideas? > > BTW, sorry for the late reply. I didn't notice this in a timely fashion. > > On Wed Jul 18 15:55:03 2018, ROMM wrote:
>> Hi guys, >> >> Great work, but in the version 1.2209 (and as I checked, in 1.2212) >> there is a problem handling out in _cmd_ok (line 1182 in 1.2209): >> >> sub _cmd_ok { >>     my ( $self, $res ) = @_; >>     my $id = $self->_count; >> >>     $self->_debug( caller, __LINE__, '_cmd_ok', $res ) if $self->{debug}; >> >>     if ( $res =~ /^$id\s+OK/i ) { >>         return 1; >> >>     } elsif ( $res =~ /^$id\s+(?:NO|BAD)(?:\s+(.+))?/i ) { >>         $self->_seterrstr( $1 || 'unknown error' ); >>         return 0; >> >>     } elsif ( $res =~ m/^\*\s+/ ) { >> >>     }else { >>         $self->_seterrstr("warning unknown return string (id=$id): $res"); >>     } >> >>     return; >> } >> >> Unfortunately, Outlook365 IMAP implementation has been noticed to >> arbitrarily close the connection sending: >> [...re/perl5/Net/IMAP/Simple.pm line 1126 in sub _process_cmd] * BYE >> Connection is closed. 13\r\n >> [...re/perl5/Net/IMAP/Simple.pm line 1277 in sub _cmd_ok] * BYE >> Connection is closed. 13\r\n >> which are thus unparsed and not taken care of. After that you can >> continue to pump commands into IMAP pipeline and after about a fifty >> such commands the script will die without a reason. >> >> I don't know what the patch should be, but at least some _seterrstr >> should be called. >> >> Thanks, >> Roman.
>


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.