Skip Menu |
 

This queue is for tickets about the Moo CPAN distribution.

Report information
The Basics
Id: 125659
Status: open
Priority: 0/
Queue: Moo

People
Owner: Nobody in particular
Requestors: perl [...] toby.ink
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: isa coderefs are able to alter the value they're passed
Download (untitled) / with headers
text/plain 171b
use v5.14; use strict; use warnings; package Foo { use Moo; has fff => (is => 'ro', isa => sub { $_[0]++ }); } my $foo = Foo->new(fff => 41); say $foo->fff; # says 42
Download (untitled) / with headers
text/plain 210b
use v5.14; use strict; use warnings; package Foo { use Moo; use Sub::Quote qw( quote_sub ); has fff => (is => 'ro', isa => quote_sub q{ $_[0]++ }); } my $foo = Foo->new(fff => 41); say $foo->fff; # says 41
Download (untitled) / with headers
text/plain 229b
use v5.14; use strict; use warnings; package Foo { use Moo; use Sub::Quote qw( quote_sub ); has fff => (is => 'ro', isa => quote_sub q{ my ($value) = @_; $value++ }); } my $foo = Foo->new(fff => 41); say $foo->fff; # says 42
Download (untitled) / with headers
text/plain 345b
Best solution might be just to document it. Something like: For efficiency, Moo will sometimes avoid copying a value before passing it to the isa check. This means the isa coderef can inadvertently modify the value that is used to construct the object. Do not rely on this behaviour as it is inconsistent and may change from version to version.
Download (untitled) / with headers
text/plain 692b
On Tue Jun 26 04:52:46 2018, TOBYINK wrote: Show quoted text
> Best solution might be just to document it. Something like: > > For efficiency, Moo will sometimes avoid copying a value before > passing it to the isa check. This means the isa coderef can > inadvertently modify the value that is used to construct the object. > Do not rely on this behaviour as it is inconsistent and may change > from version to version.
I think that seems reasonable. It will always be possible to modify the value being checked in some cases (references) so I don't think there is a strong case for changing the current behavior. If someone does come up with a more concrete problem with this, it can always be revisited.
Download (untitled) / with headers
text/plain 458b
For reference, this is Moose's behaviour: Inlined type constraints *can* alter the value. Non-inlined type constraints can't. (Or at least, I haven't been able to trick them into changing the value.) perl -E'package Foo { use Moose; use Moose::Util::TypeConstraints; subtype "NonNeg", as "Int", where { ++$_[0] > 0 }, inline_as { "++$_[1] > 0" }; has foo => (is => "ro", isa => "NonNeg"); __PACKAGE__->meta->make_immutable}; say Foo->new(foo => 41)->foo'
Subject: Re: [rt.cpan.org #125659] isa coderefs are able to alter the value they're passed
Date: Mon, 2 Jul 2018 09:55:56 -0700
To: bug-Moo [...] rt.cpan.org
From: Karen Etheridge <karen [...] froods.org>
Download (untitled) / with headers
text/plain 812b
Especially since whether a type is inlined should be invisible to the user, I would argue this is unintentional in Moose, and we should fix it there as well. On Mon, Jul 2, 2018 at 2:41 AM, Toby Inkster via RT <bug-Moo@rt.cpan.org> wrote: Show quoted text
> Queue: Moo > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=125659 > > > For reference, this is Moose's behaviour: > > Inlined type constraints *can* alter the value. > > Non-inlined type constraints can't. (Or at least, I haven't been able to > trick them into changing the value.) > > > perl -E'package Foo { use Moose; use Moose::Util::TypeConstraints; subtype > "NonNeg", as "Int", where { ++$_[0] > 0 }, inline_as { "++$_[1] > 0" }; has > foo => (is => "ro", isa => "NonNeg"); __PACKAGE__->meta->make_immutable}; > say Foo->new(foo => 41)->foo' >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.